On Tue, Aug 22, 2017 at 09:46:38AM -0300, Rodrigo wrote: > > > > Please switch to the debhelper compat level 10. > > Not fixed. > The debhelper version is set to (>= 10) on debian/control. Is that what you > meant? No, debian/compat sets the compat level. > > > > Why Vcs-Git but no Vcs-Browser? > > Not answered. > The source code is only on GitHub, that's why we used only Vcs-Git. Is that > correct? Why would it? "Vcs-Browser URL of a web interface for browsing the repository." Do I understand correctly that postinst touches /opt? Including /opt/bin? I'm not sure that's a good idea even if that's only for migration (and it's definitely a bad idea if anything in /opt is created on a clean system). As the maintainer script logic is very complex, please carefully test your packgages with piuparts(1). Why does the build process depend on $BLOCK_FILEMODE_OVERRIDE? unexport LD_PRELOAD may be a bad idea. cxlflash-test.install was not removed. src/include/fuse.* and src/include/scsi/cxlflash_ioctl.h licenses and copyrights aren't listed in debian/copyright. By the way, Apache 2.0 isn't compatible with LGPLv2 (though FUSE headers don't seem to be used) and a combined work of the Apache 2.0 sources and a GPL2+ src/include/scsi/cxlflash_ioctl.h is, AFAIK, under GPL3+ and not Apache 2.0. -- WBR, wRAR
Attachment:
signature.asc
Description: PGP signature