[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#872828: RFS: node-regjsgen/0.3.0-1 ITP



Re,

Le 21/08/2017 à 22:31, Bastien ROUCARIES a écrit :
> Will sponsor

Thanks!

> On Mon, Aug 21, 2017 at 10:25 PM, Bastien ROUCARIES
> <roucaries.bastien@gmail.com> wrote:
>> control: owner -1 rouca@debian.org
>>
>> On Mon, Aug 21, 2017 at 9:52 PM, Julien Puydt <julien.puydt@laposte.net> wrote:
>>> Hi,
>>>
>>> Le 21/08/2017 à 20:54, Bastien Roucaries a écrit :
>>>>>   Section         : web
>>>>
>>>> Section: JavaScript
>>>
>>> Changed.
>>>
>>> Snark on #debian-js
>>>
> 
> Some remark:
> - watch is now version 4

Ok -- I'll have to check what goodies there are in this version.

> - copyright only 2017 and one author what give git log about year and author ?

The logs show Benjamin Tan and small contributions from Mathias Bynens.
I pushed a change on the dates.

> - test data json does not build from source. This need a repack (use
> copyright file excluded and uscan. It is free but FTBFS so add +ds
> suffix)

Are you sure? The tests/ directory isn't used at all by my packaging, so
it shouldn't be a FTBFS.

> - a small smoke test supplied as example and run will help

I added debian/tests/compose and debian/example.js (shipped in
/usr/share/doc/node-regjsgen).

Snark on #debian-js


Reply to: