[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#864946: RFS: libsml/0.1.1+git20170608-1 [ITP]

Control: tags -1 -moreinfo

On Tue, Jul 25, 2017 at 08:17:23PM +0500, Andrey Rahmatullin wrote:


thanks for your review.

> Please use Priority: optional.


> CONTRIBUTION.pdf should be removed from the orig tarball as it doesn't
> have a source and I doubt is even free (actually license texts we ship are
> also non-free, but still we have the requirement to ship PDF sources).

Ok, removed it during the repack-step of get-orig-source.

> The upstream "make all" runs the tests, we usually don't do that, but I
> don't know in this case why can that be bad.

The upstream build system unfortunately isn't very sophisticated, but it does 
its job and running the tests is quick and useful.

> Otherwise the package is good.


Updated package uploaded to mentors.

PGP-encrypted mails preferred
PGP Fingerprint: 74CD D9FE 5BCB FE0D 13EE 8EEA 61F3 4426 74DE 6624

Attachment: signature.asc
Description: PGP signature

Reply to: