[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#858733: RFS: clickhouse/1.1.54190-1 [ITP]

Control: tags -1 + moreinfo

Some preliminary remarks:

Why B-D specifically on gcc-6, g++-6?
Version in Depends: lsb-base (>= 3.2-14) can be dropped.
Current Standards-Version is 4.0.0.
Current debian/compat is 10.
Are you sure this Pre-Depends usage is correct? Have you discussed it as
required by the Policy? I suppose it's because clickhouse-client.postinst
uses the user created in clickhouse-common.postinst but I don't think it
is needed in this case.
Besides, I think you shouldn't use chown to change ownership, see
Besides, I don't think it's advisable to have a dir in /etc owned by a
service user (while the group will remain root? why?).
The current consensus is to not delete users on purge.
AUTHORS and README.md are included in several subpackages, this seems
wrong. And in debian/clickhouse-utils.docs they are listed twice.
There seems to be a typo in the PID file name in
Some of the descriptions miss the trailing period.
Is debian/copy_clang_binaries.sh unused?
debian/libclickhouse1.symbols is empty.
debian/copyright is very wrong with a single copyright and license for the
entire project: it lacks licenses and copyrights for all bundled third-party
code, there are several MIT-licensed files in the main code and docs, and
that's without doing a full analysis.

Now to debian/rules.
Why --max-parallel=4?
override_dh_auto_clean runs dh_clean, not dh_auto_clean, and it also does
a bunch of rm's while dh_clean can do that with debian/clean.
I think removing embedded copies should be done in clean, not in build.
dh_auto_configure should run cmake, not override_dh_auto_build.
Manual make -j`grep -c ^processor /proc/cpuinfo` is wrong.
"will wait for the ability to use system libs instead of contrib ones"
comment is worrying, so did that already happen or not? 
copy_headers.sh seems wrong.
dh_install --sourcedir=debian/tmp is the default, isn't it? In any case it
shouldn't be run in override_dh_auto_install.
Creating dirs should be done by dh_installdirs.

And the build fails in sbuild:

grep: ../../debian/clickhouse-server-config-tests-preprocessed.xml: No such file or directory
grep: /etc/clickhouse-server/config-preprocessed.xml: No such file or directory

Running stateless tests.

00001_select_1:                                                        [ FAIL ] - return code 232
/usr/share/zoneinfo/Asia/Yekaterinburg: No such file or directory
Poco::Exception: Exception: Cannot load time zone Asia/Yekaterinburg
00039_inserts_through_http:                                            [ FAIL ] - return code 7
curl: (7) Failed to connect to localhost port 8123: Connection refused
Having 58 errors!
./debian/tests_wrapper.sh: line 30: 31404 Aborted                 (core dumped) PATH=$PATH:./build/dbms/src/Server ./build/dbms/src/Server/clickhouse-server --config-file=./debian/clickhouse-server-config-tests.xml 2> /dev/null  (wd: /<<PKGBUILDDIR>>)
./debian/tests_wrapper.sh: line 18: kill: (31404) - No such process
debian/rules:31: recipe for target 'override_dh_auto_test' failed


Attachment: signature.asc
Description: PGP signature

Reply to: