[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#851937: RFS: farbfeld/2.20170109-1 ITP

control: tag -1 +moreinfo

On Wed, Jul 12, 2017 at 02:58:48PM +0200, Paride Legovini wrote:
> Following up from the brief discussion we had on #debian-devel, here is
> a tentative package:
> https://anonscm.debian.org/cgit/users/paride-guest/farbfeld.git/

Thanks again for your help with this RFS.  Here is a review of 534d41f:

- I think we should list Dmitry in the Uploaders: field, which would
  indicate that he may upload new versions of the package without it
  counting as an NMU

- your git history does not really give credit to Dmitry for his work.
  I'd like to suggest starting again, and doing it like this:

  + clone Dmitry's repo
  + `git merge 3` to get the new upstream version
  + revert the convert commit (but see below)
  + apply your other changes

- I also think it would be good to state in debian/changelog that most
  of the Debianisation is due to Dmitry

- your changes to the patch header do not make sense: the '3..' will not
  yield "the changes made by the Debian maintainer in the first upload
  of upstream version 3".  Please take another look at the template.

- I disagree with you about Dmitry's `convert` patch.  It just doesn't
  seem likely to me that there would be difficult merge conflicts with
  new upstream versions, and it is indeed useful to inform the user that
  convert is not available.  But I will defer to your judgement -- if
  you're sure about dropping the patch, maybe imagemagick should be
  moved to a hard dependency?

If you're able to address the issues I've raised in this message, please
remove the moreinfo tag in this bug, and don't forget to re-run `dch -r`
to refresh the changelog timestamp.

Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply to: