[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#849273: RFS: gemmlowp/0~20170407-g719389f-1 [ITP]



Hi Lumin,

Thanks a lot. The package LGTM. Sponsored. Will be in NEW queue soon.

Yours,
Paul


On Fri, Jun 23, 2017 at 10:45 AM, Lumin <cdluminate@gmail.com> wrote:
Hi,

On 17 June 2017 at 13:08, Ying-Chun Liu (PaulLiu) <paulliu@debian.org> wrote:
>
> Just a few things left.
>
> 1. It is called README.source not README.Source
>   The 's' should be in lower case.

Renamed.

> 2. I found that the copyright holder should have
>  "Silk Labs Inc." in AUTHORS file.
> And also some of the header files show that the copyright holder are
> "2015 The Gemmlowp Authors"
> Please also add these to debian/copyright.

Updated copyright.

The updated package was uploaded to mentors

https://mentors.debian.net/debian/pool/main/g/gemmlowp/gemmlowp_0~20170609-g36ffd29-1.dsc

as well as debomatic

http://debomatic-amd64.debian.net/distribution#experimental/gemmlowp/0~20170609-g36ffd29-1/buildlog

> For tensorflow, if possible, we can just patch the cmake file by quilt
> and let it built against the libraries in system. I'll try to make a
> patch. Or perhaps you can tell me where the feature request is and I'll
> see if I can help.

Yes, we can patch the cmake files.
The feature request is located here:

https://github.com/tensorflow/tensorflow/issues/9298

But no one seems to be interested in it.
I attempted to patch the cmake files but it's still a WIP,
and the patch is attached. Feel free to use it if it's useful.

My idea was to guard those external project cmake files
with tensorflow_USE_SYSTEM_XXX flags just like what
Julialang has done.

--
Best,
Lumin


Reply to: