control: tag -1 +moreinfo
Dear Branden,
Please accept my apologies for letting this RFS sit for so long. Thank
you for all your work. Looking forward to uploading it soon.
Here's a full review of dc84e1861798b3aba0969e2fe81a2431f2ee17de:
Should be fixed
===============
1. Maybe we should just upload to unstable, DELAYED/7, because the
freeze will be over this weekend? Would save another RFS next week.
2. Lintian says
W: xtrs source: file-without-copyright-information .gitignore
.gitignore is not copyrightable, so there is no bug, but I think it
would be best to add a Lintian override. Then the package will be
Lintian-clean.
3. The orig.tar doesn't seem to be the same as the one available from
upstream:
zephyr ~ % shasum tmp/xtrs-4.9d.tar.gz rfs/xtrs_4.9d.orig.tar.gz
72b99ede6e8024b8ade4f8aa22eb073078576e74 tmp/xtrs-4.9d.tar.gz
42b1fc90246901456d29071421e838b545f39f0f rfs/xtrs_4.9d.orig.tar.gz
Do you know why? (I'm working from git, but I grabbed the orig.tar from
mentors.)
4. A few things not mentioned in the changelog:
- new d/clean
- new d/watch
- deleted d/dirs
- debhelper compat bump
- rewrite d/rules & switch to use dh sequencer (not the same as
compat bump)
- add d/xtrs.install
- std-ver bump (it would be reassuring to see "no changes required")
- new build deps, e.g. bsdmainutils (btw, really nice commenting of
the build-deps)
- postinst tidied up (changes to maintscripts should always be
mentioned in the changelog, since they are such a frequent source
of bugs)
- various patches in d/patches are not in d/changelog. it might also
be a good idea to give the patch name, instead of just the file
modified, so someone can track down the change
5. Copyright file issues:
- id.po and nl.po seem to have broken template "Copyright (C)" lines.
- you need entries in d/copyright for the *.po files. Or you could just
add the author's names to the stanza for debian/*.
- The FSF hold copyright on some code in *-idiomatize-manpage.patch
Suggestions
===========
1. You could use debhelper compat 10.
2. You could uncomment Vcs-* and fill in the address of your alioth
repo.
3. Typo "appply" in xtrs.doc-base.cpmutil.
4. I think that cpmutil.dsk and utility.dsk should go into
/usr/share/xtrs not /usr/lib/xtrs, since they are binary but not
architecture-dependent
5. emtsafe-flag-on-by-default.patch would benefit from a description
explaining why it's a good idea.
If you're able to address the issues I've raised in this message, please
remove the moreinfo tag in this bug, and don't forget to re-run `dch -r`
to refresh the changelog timestamp.
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature