Hi Stephen many thanks for your review. Am Samstag, den 10.06.2017, 09:43 +0200 schrieb Stephen Kitt: > Hi Jörg, > > On Mon, 05 Jun 2017 12:00:41 +0200, Jörg Frings-Fürst > <debian@jff-webhosting.net> wrote: > > Alternatively, one can download the package with dget using this > > command: > > > > dget -x > > https://mentors.debian.net/debian/pool/main/libu/libunistring/libunistring_0.9.7-1.dsc > > Thanks for taking care of this. Here are my review notes. > > * I noticed you’ve added symbols files specifically for amd64 and i386; they > are identical and there’s nothing there which should vary across > architectures, is there any reason not to have a generic symbols file? > Ok. I have now only the libunistring2.symbols file. > * The contents of DEVELOP.Debian would fit nicely in a README.source instead, > IMO > (https://www.debian.org/doc/debian-policy/ch-source.html#s-readmesource). > Thanks for the hint. I renamed the file accordingly. > * Since you’re no longer using cdbs, the relevant lines in debian/rules could > be entirely removed rather than commented. The commeents are removed. I have upload the package to mentors[1] again. > > Regards, > > Stephen Have a nice weekend. CU Jörg [1] https://mentors.debian.net/debian/pool/main/libu/libunistring/libunistring_0.9.7-1.dsc -- New: GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB 30EE 09F8 9F3C 8CA1 D25D GPG key (long) : 09F89F3C8CA1D25D GPG Key : 8CA1D25D CAcert Key S/N : 0E:D4:56 Old pgp Key: BE581B6E (revoked since 2014-12-31). Jörg Frings-Fürst D-54470 Lieser Threema: SYR8SJXB Wire: @joergfringsfuerst IRC: j_f-f@freenode.net j_f-f@oftc.net My wish list: - Please send me a picture from the nature at your home.
Attachment:
signature.asc
Description: This is a digitally signed message part