[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#862371: RFS: budgie-desktop/10.3.1-1



Tim,

  absolutely superb - that worked very nicely :D

Not quite sure I understand why since I dont recognise that locale -
some-sort of special "C language" unicode locale? - but it works so
thats the main thing.


Gianfranco,

  A new version of the package has been uploaded with Tim's
suggestion.  Tested by building in a Stretch chroot.

In addition - as requested - the .installs have been simplified.

I also doubled checked this and threw this up on a launchpad PPA.

cheers

David

On 4 June 2017 at 22:15, Tim Dengel <tim.dengel.debian@gmail.com> wrote:
> Hi David,
>
> I haven't specifically looked into your issue and the build log doesn't
> seem to be available anymore, but it sounds like you're having trouble
> with meson being unable to deal with Unicode symbols inside a pbuilder
> chroot.
> I also have a package that builds with meson and had a FTBFS due to
> Unicode support (gnome-twitch), although admittedly it is a much simpler
> package than budgie. I fixed my issue by adding LC_ALL=C.UTF-8 in the
> d/rules file[0]. Maybe it helps.
>
> [0] https://github.com/dengelt/gnome-twitch/blob/debian/sid/debian/rules
>
>
> Regards,
>
> Tim
>
>
> Am 04.06.2017 um 19:46 schrieb foss.freedom:
>> Hi Gianfranco,
>>
>>   I'm struggling with this - any thoughts on my investigations below.
>>
>> On Debian Stretch I've created a chroot for unstable and installed the
>> build dependencies for budgie-desktop + locales + meson
>>
>> In debian/rules I've changed the two export LANG and LANGUAGE vars to
>> en_US.UTF-8
>>
>> Then manually (in the chroot) I have run the following:
>>
>> debconf-set-selections <<< 'locales locales/default_environment_locale
>> select en_US.UTF-8'
>>
>> dpkg-reconfigure locales
>>
>> update-locale LANGUAGE='en_US.UTF-8'
>>
>> N.B. the debconf-set-selections is to ensure dpkg-reconfigure locales
>> runs without the user having to manually select en_US.UTF-8 to the two
>> questions asked.
>>
>> That's enough to convince the dpkg-buildpackage -us -uc to work
>> correctly within the chroot
>>
>> The question I have is how to tuck the three commands above into the
>> Debian package to run before the main meson callout in debian/rules ?
>> i.e. I'm hoping this is the answer how to get the Debian build system
>> to default to a UTF-8 locale.
>>
>> I added the three commands within override_dh_auto_configure: but I
>> get a "sh:1  Syntax error: redirection unexpected" - so I'm kind of
>> stuck on how to move forward.
>>
>> I was hoping to find an existing Debian package that uses meson
>> building Vala within the archives to see how the maintainer did
>> something similar but my Google-fu has failed to find such a package
>> :(
>>
>> David
>>
>>
>> On 12 May 2017 at 19:09, foss.freedom <foss.freedom@gmail.com> wrote:
>>> Thanks Gianfranco for the review.  Much appreciated.
>>>
>>> I have completely redone the licenses and files in debian/copyight and
>>> double checked via "check-all-the-things"
>>>
>>> For the .install files - all debian/tmp has been removed.
>>>
>>> the FTBFS is concerning.  I don't understand why there is a difference
>>> between the build systems of launchpad (it works) and Debian (it
>>> doesnt).
>>>
>>> I asked this question here -
>>> https://github.com/budgie-desktop/budgie-desktop/issues/921
>>>
>>> The advice is to ensure the environment variables LANG and LANGUAGE is
>>> set to en_US - I've added two export lines for these environment vars
>>> at the top of the debian/rules
>>>
>>> I've tested the rules changes on launchpad.  However I dont have
>>> access to the debian build system so I cannot verify.
>>>
>>> I have rebuilt on my debian stretch VM and this is OK.
>>>
>>> David
>>>
>>> On 11 May 2017 at 22:27, Gianfranco Costamagna <locutusofborg@debian.org> wrote:
>>>> control: owner -1 !
>>>> control: tags -1 moreinfo
>>>>
>>>> Hello, I will sponsor it,
>>>> but please have a deep look at missing copyrights for a next upload, e.g.
>>>> + * Copyright (C) 2017 taaem <taaem@mailbox.org>
>>>>
>>>>
>>>> other things:
>>>> I don't understand why you prepended debian/tmp to install files, but as you wish
>>>>
>>>> 2) FTBFS
>>>> http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog
>>>>
>>>> G.
>>


Reply to: