control: tag -1 -moreinfo Sean, thanks for the review. Issues should all be addressed now. > Here is a review of 5a5d084bf540c903d4ea19f9761da2d6b38b3907: > > - It FTBFS. I've attached a log. Took a bit of work to reproduce this one. Restricting a VM to a single core, and stressing that to 100% during build did the trick. Turned out the test was expecting a 1.* value for latency but a system with limited resources would exceed that. Added a patch so that it will accept any latency value >= 1ms (the test has a usleep(1000) statement that ensures that minimum); also forwarded upstream. > An optional wishlist item: > > - crc32tbl.h is a generated file, and ideally it would be regenerated > during the package build. I understand the sentiment, but in this case that seems unnecessary. Looking at the code in crc32.c that table never changes, and it being generated rather than "hand made" was probably a mere choice of convenience for its original author. Upstream version was bumped to newly released v1.0.7 in the process. Git branch for use with dgit-maint-gbp workflow is available at: https://github.com/jcfp/debpkg-sysbench/tree/master/ HEAD commit id 5c1deac8b197e6de7bce29b7341829023fa17202 As requested in dgit-sponsorship(7), some sample commands: To generate the orig tarball: origtargz or using pristine-tar directly: pristine-tar checkout ../sysbench_1.0.7+ds.orig.tar.gz To build the source package: dgit --gbp build-source To Upload: dgit --gbp push
Attachment:
pgpJL72nOoYFW.pgp
Description: OpenPGP digital signature