Re: Bug#861754: libpll: FTBFS on non-x86: x86intrin.h: No such file or directory

[Christian Seiler <christian@iwakd.de>]

Hi,

a small comment on the patch:

On 05/16/2017 01:28 PM, James Cowgill wrote:
>  override_dh_auto_configure:
> -	./autogen.sh
> -ifeq ($(DEB_BUILD_ARCH),i386)
> -	./autogen.sh --disable-avx --disable-sse
> -	dh_auto_configure -- --disable-avx --disable-sse
> +ifneq ($(filter $(DEB_HOST_ARCH_CPU), amd64 i386),)
> +	dh_auto_configure
>  else
> -	./autogen.sh --disable-avx
> -	dh_auto_configure -- --disable-avx
> +	dh_auto_configure -- --disable-sse --disable-avx --disable-avx2
>  endif

At first glance this appears to be wrong, as SSE2 is part of the
amd64 base ISA. However, --disable-sse actually disables SSE3
(not part of amd64 base ISA), so it's not actually wrong - you'd
probably want to add a comment to d/rules that indicates that
--disable-sse is for SSE3 though.

Also, you should add x32 to the list of archs next to amd64 and
i386 where SSE3 and higher should be disabled.

Regards,
Christian