Bug#858538: fadecut package review
Hi Marco,
bash consiedered to be an "essential" package, so
you should probably not depend on it. It should be
in the system.
I do not understand, what you mean with "killed my orbis-tools|lame rule".
As far as I see, dependencies were just aligned.
Debian is deeply frozen at the moment, but the stable will be released
very soon. We can wait a coupe of weexs till Debian will be released.
Otherwise uploads into experimental are possible.
Best regards
Anton
2017-04-22 16:27 GMT+02:00 Marco Balmer <marco@balmer.name>:
> Hi Anton,
>
> Thank you for your reply.
>
> On Wed, Apr 12, 2017 at 09:29:19PM +0200, Anton Gladky wrote:
>> there are a couple of minor notes regarding your package:
>>
>> 1) integrate changes from NMU two years ago [1] (to be consistent d/changelog)
>> 2) Try to use compat level 10 and debhelper >=10.
>> 3) Use "cme fix dpkg" over your package to fix minor issues
> I am done with all this steps [1].
>
> cme fix dpkg [2] has
> * killed my vorbis-tools|lame rule
> * removed Depends bash (>=3.2-4)
> But fadecut needs bash. Is that ok?
>
> Thanks for help,
> Marco
>
> [1] https://mentors.debian.net/debian/pool/main/f/fadecut/fadecut_0.2.0-1.dsc
>
> [2] https://github.com/fadecut/fadecut/commit/f58c7a2086743e5a63fa1ed1298895fbec652af8#diff-d837a1c17de0268bcea321239ddbed47L13
Reply to: