Control: tag -1 moreinfo
Control: owner -1 !
On Mon, Apr 24, 2017 at 01:36:46PM +0200, Félix Sipma wrote:
> I am looking for a sponsor for "golang-github-pkg-xattr":
hi there!
> gbp clone --pristine-tar https://anonscm.debian.org/git/pkg-go/packages/golang-github-pkg-xattr.git
You are doing some really bad, actually, namely defining
DEB_BUILD_OPTIONS in d/rules. I thought lintian had a check for this.
Please don't do this: either use DEB_BUILD_MAINT_OPTIONS, or add an
empty dh_auto_test override. In both cases, I would appreciate if you
could add that comment you added in the git commit message directly as a
comment to d/rules, so people can wonder less on why you disabled the
tests.
Besides, why not just exporting the variable, instead of doing the way
you did it?
Also, can you write a tad longer description? (lintian does complain
about this).
I am not sure of the general rules within the go team, but usually I
prefer when people don't do debian/ tag unless they are 100% sure that's
what is going to be uploaded. In this case you are now forced to either
remove that tag (and then I have to manually remove it locally too…, and
so are all the people who have already cloned that repo), or bump the
version which is probably even uglier…
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature