Dear Andrew, Thank you for reviewing my package! On Tue, 18 Apr 2017 22:46:19 -0400 Andrew Starr-Bochicchio <asb@debian.org> wrote: > On Wed, Mar 22, 2017 at 10:13 AM, Roger Shimizu <rogershimizu@gmail.com> wrote: > > I am looking for a sponsor for my package "simple-obfs", which is a new > > dependency of shadowsocks-libev since v3.0.3 > > Hi Roger, > > Great work! Though there are a few things to address before uploading. > The largest ones are around the watch file and upstream tarball: > > The watch file as provided seems to have an issue with the regex used > for filenamemangle and fails to download the upstream tarball. Running > uscan errors out with: > > uscan warn: stop mangling: > rule="s%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%simple-obfs-$1.tar.gz%"" > rule doesn't match "(s|tr|y)%.*%.*%[a-z]*" (or similar). > uscan warn: In debian/watch, potentially unsafe or malformed > filenamemangle pattern: > 's%(?:.*?)?v?(\d[\d.]*)\.tar\.gz%simple-obfs-$1.tar.gz%"' found. > Skipping watchline > https://github.com/shadowsocks/simple-obfs/tags > (?:.*?/)?v?(\d[\d.]*)\.tar\.gz debian uupdate I find a '"' mark missing: https://github.com/rogers0/simple-obfs/commit/f94908a After this fix, uscan can sucessfully scan and download latest upstream tarball. > Additionally, the upstream tarball I found on the project's GitHub > page [0] does not match the one provided on mentors. > > $ md5sum simple-obfs-0.0.3.tar.gz > 7daebe04043402fa61616c958140c24e simple-obfs-0.0.3.tar.gz > > $ md5sum simple-obfs_0.0.3.orig.tar.xz > edf878d5cd84416bd9241862e0c58e0a simple-obfs_0.0.3.orig.tar.xz Original idea was to remove some autotools files by adding to Excluded-Files: in d/copyright, and repack the upstream tarball. But finally it seems not necessary, so yes, simply using upstream's tarball is fine. Fixed by force push pristine-tar branch. > A few minor points: > > - The package description could be expanded on a bit. Referring to the > README.md and manpages isn't all that useful as the user would likely > not have the package installed. The description should help a user > understand what purpose the package serves but does not need to get > into usage details. I picked a few words from manpage to add to description. > - The control file does not contain Vcs-* [1] fields. [1] Also, while > it is not a hard requirement, using Debian infrastructure (i.e. > git.debian.org) rather than GitHub would be prefered. Added collab-maint git repo to d/control. Though not created yet, I'll push to alioth after your upload. > - If desired, targeting unstable would be fine as this is a new > package and will not cause issues with getting changes into testing. Fixed. New commits are pushed to branch mentors2. And here're updated mentors & DoM url: https://mentors.debian.net/debian/pool/main/s/simple-obfs/simple-obfs_0.0.3-1.dsc http://debomatic-amd64.debian.net/distribution#unstable/simple-obfs/0.0.3-1/buildlog Thanks again! Cheers, -- Roger Shimizu, GMT +9 Tokyo PGP/GPG: 4096R/6C6ACD6417B3ACB1
Attachment:
pgpP7tXcZVUrw.pgp
Description: PGP signature