[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#859238: RFS: microsoft-gsl/0.1~2017.03.20~git16a6a41-1



Control: retitle 859221 ITP: ms-gsl -- Microsoft Guidelines Support Library
Control: reitle -1 RFS: ms-gsl/0~git20170403.ebab8ca-1

On Sat, Apr 08, 2017 at 05:33:35PM +0300, Коля Гурьев wrote:
> 04.04.2017 03:22, Mattia Rizzolo пишет:
> > As I said privately, I'd enjoy having a git repository for this :)
> > Here I feel you could enjoy even more baing the repo out of upstream
> > git (see an example in the dehydrated package); or you can see my
> > pencil2d package for an example of a thing building tarball out of
> > upstream git, ready to be committed; as you prefer.
> 
> I temporally uploaded my repo to GitHub [1]

Nice, would you also please push upstream and prisitine-tar branches?
(you may name upstream and debian branches as you see fit, just be sure
HEAD points to the packaging branch and debian/gbp.conf reflects the
reality if it's not the default)

> I believe alioth.debian.org
> will be a better location. I've registered there (my username is
> mymedia-guest) just now.

As you saw, I made a request for you to access collab-maint.

> I also made get-orig-source target in d/rules. It clones the upstream
> repository and pack it in a tar archive. I made it because I hadn't found
> any tarball on upstream GitHub.

Cool.

> > * test building, I noticed it didn't take advantage of my quad-core
> >   system; why didn't you use compat level 10?
> 
> I'm Ubuntu user, but there is only debhelper of version 9 in ubuntu
> repositories. So I added --parallel option into d/rules file as an interim
> solution.

Look better, debhelper >= 10 is available in xenial, yakkety and zesty.
Besides, in theory you are supposed to test your packages in Debian too
:P

Also, it shouldn't matter much, as you should be building your packages
in the current development version, using a chroot (see tools like
pbuilder or sbuild).


BTW, being an ubuntu user you might also consider to subscribe to the
launchpad package.  An Ubuntu developer (it wasn't me!) synced the
package in Ubuntu zesty already, and there is already a bug open there
too https://launchpad.net/ubuntu/+source/telegram-desktop (same for
ms-gsl once it will be there).
Just so you know, I have upload rights to Ubuntu's universe too (i.e. I
am a MOTU).

> > * please send that UnitTest.patch upstream; that's clearly one of those
> >   cases their stupid system with a case-insensitive file system tricked
> >   them…
> 
> It seems the upstream doesn't need this patch because they use a last
> version of UnitTeset++ framework where the header has capital letters.

| + In libunittest++ debian package others paths are.

The grammar of this sentence is off :)
I suggest "In the libunittest++ debian package the paths are different".
But is it really just a debian thing? :O  Or upstream changed something?

> [1] https://github.com/mymedia2/ms-gsl



-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: