Hi Hugo, thanks again for the review and the comments! On Wed, 5 Apr 2017 18:25:04 +0200 Hugo Lefeuvre <hle@debian.org> wrote: > > * debian-watch-may-check-gpg-signature > > I wouldn't override debian-watch-may-check-gpg-signature btw. Ok, I will revert that override. > > If I remove `usr/sbin` from dirs, buildpackage fails complaining > > that the directory does not exist (so something in the build system > > is slightly broken). > > The error message is > > /usr/bin/install -c -m 555 -o bin -g bin > arpwatch /build/arpwatch-2.1a15/debian/arpwatch/usr/sbin /usr/bin/install: > cannot create regular file > '/build/arpwatch-2.1a15/debian/arpwatch/usr/sbin': No such file or > directory Makefile:114: recipe for target 'install' failed > > looks like the Makefile installs files under usr/sbin, but doesn't > create the directory if it doesn't exist. This is rather a Makefile > bug. With "build system" I meant this process of autotools creating the Makefile, and `make install` doing something slightly wrong. Anyway, that means keeping `usr/sbin` in the dirs file is the correct "fix", right? > If the dpkg documentation recommends to do so, then, fine, forget > about this warning. But it also makes sense to drop dpkg version constraints at some point. I wonder if it's not better to ask the dpkg maintainers if that recommendation still holds… > Are you already a member of the team ? If yes, could you move your git > repository to > https://anonscm.debian.org/git/pkg-security/arpwatch.git ? I'm not a member of the team yet, where can I apply? :) Disclaimer: this is my first package… When pushing to the repository, should the changes go into a separate branch for experimental (e.g. debian/experimental instead of debian/master)? Also I'm uncertain if I should add ~exp1 to the version number. Some packages seem to do it for experimental uploads, others don't and just increment the version number once when uploading to unstable later. Do you have a recommendation? I have the following on my TODO list which I would like to resolve before the upload: * decide on whether to add ~exp1 to version number * remove the override for debian-watch-may-check-gpg-signature * update debian/changelog timestamp (which I forgot to do after yesterday's changes) * git-tag the release and push the git repository to its new home Regards Lukas
Attachment:
pgpq_CfDaM3Ed.pgp
Description: OpenPGP digital signature