[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]



Dear Jeroen,

On Sun, Mar 12, 2017 at 09:04:07PM -0700, Jeroen van Aart wrote:
> I gave it version -2 because I initially had uploaded a -1 version to
> mentors. There were some lintian warnings and I fixed those, that's why I
> bumped the version to -2. If it is a problem I can change it back again,

No, it's fine.  It's just a convention that version numbers are
incremented for uploads to the archive, not uploads to mentors.  Please
try to follow it in the future, just to avoid any confusion.

> I just double checked, when I get the above two version and create a
> debdiff, and then download the debdiff from the unblock request
> (https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=857118;filename=debdiff_xfce4-equake_v138-1_v1381-2.diff.gz;msg=5)
> and then run a diff between those the files turn out to be exactly the
> same.
> 
> Maybe you checked against the xfce4-equake-plugin_1.3.8.1-1.dsc version in
> mentors? If so, I apologise for the confusion.

That wasn't the problem.  I was failing to pass -p1 to interdiff.  Thank
you for double checking, anyway.

I'd like to see some improvements to your changelog before uploading
this.

- changes to d/copyright not documented

- the last point about avoiding lintian warnings is unnecessarily
  brief.  Please expand it.  There is a convention for std-ver changes:

  * Bump standards version to 3.9.8 (no changes required).

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: