Bug#853903: RFS: scap-security-guide/0.1.31-6 [ITP] -- security guides and conformity checks using SCAP standard
Le 2017-03-02 14:59, Gianfranco Costamagna a écrit :
Hi,
Hi,
"please use "unstable" as target suite, not "sid", and use -1 revision
until it gets sponsored (dput -f, mentors won't complain)
Ok, I will patch the distrib name (and the branch name in the same
time)
because gbp and pbuilder works in a clean environment, they don't build
it twice
in the same location.
I have to check again but should be cleaner now.
yes, having something to copy-paste might be useful
Updated in consequence.
and now the new review:
that debian/lib and python changelog patch does not scale
(version hardcoded in python script).
I prefer no changelog instead of something hacky like this...
in the future I really would like to see upstream shipping the
changelog
The upstream team doesn't want to ship the changelog file (we had a
discussion about that). I've updated the python file to be more generic
(based on the upstream version set on the changelog file to get the
ReleaseNote file).
The corresponding makefile target is set to voluntary fails, as it
should not be executed at dpkg-buildpackage time but manually (same
principle as the debian/control-real target of the linux-grsec debian
package). The python script has been updated to be clearly cleaner.
other stuff seems good to me
G.
Thank you !
--
Philippe THIERRY
Doctor - Engineer
RT and hardened Embedded Systems
+33(0)6.64.16.97.30
Reply to: