Re: RFC: jbig2enc -- JBIG2 encoder
Hi Rogério,
My suggestions:
1. d/changelog:
- You don't need to put each change in d/changelog, considering that
this is a initial release. However, it isn't wrong.
- The bug #512518 is already closed.
2. d/copyright:
- The copyright notice is for Google Inc., not for Adam Langley. So,
IMO, Google should be mentioned in d/copyright. Adam's name is
optional (can be mentioned).
- The start date for Google is 2006 (file COPYING).
- If you want to quote all authors, there is another person: Radim
Hatlapatka (file src/jbig2comparator.h).
- To find all authors, you can use:
$ egrep -sriA25 '(copyright|public dom)' *
3. d/manpage.1.ex
- The .ex suffix must be removed.
- I suggest rename to jbig2enc.1
- You need a d/manpages file to install the manpage (currently, your
package have not a manpage). ($ man dh_installman)
- You can use txt2man to generate manpages easilly. (read the manpage
- is short)
4. d/rules:
- There are some trash in d/rules.My suggestion is to remove the
following lines: 2, 3, 6 (blank), 7, 10-15, 20-25.
- Considering that you are using DH 10, the '--with autoreconf' addon
is dispensable because DH 10 already implements autoreconf by default.
5. Is a good practice only create overrides for lintians when getting
false positives. So, I think that the debian/source/lintian-overrides
should be dropped.
6. d/watch: the first line can be dropped to save space inside the servers.
7. After build, I can see:
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/jbig2enc/usr/bin/jbig2 was not linked against libpng16.so.16
(it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/jbig2enc/usr/bin/jbig2 was not linked against libz.so.1 (it
uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/libjbig2enc0/usr/lib/x86_64-linux-gnu/libjbig2enc.so.0.0.28 was
not linked against libz.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if
debian/libjbig2enc0/usr/lib/x86_64-linux-gnu/libjbig2enc.so.0.0.28 was
not linked against libpng16.so.16 (it uses none of the library's
symbols)
You can fix some warnings with the following line in d/rules:
export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
I also can see the following warnings:
dpkg-gencontrol: warning: Depends field of package jbig2enc: unknown
substitution variable ${python:Depends}
dpkg-gencontrol: warning: Depends field of package jbig2enc: unknown
substitution variable ${python:Depends}
dpkg-gencontrol: warning: Depends field of package libjbig2enc0:
unknown substitution variable ${python:Depends}
dpkg-gencontrol: warning: Depends field of package libjbig2enc0:
unknown substitution variable ${python:Depends}
dpkg-gencontrol: warning: Depends field of package libjbig2enc-dev:
unknown substitution variable ${python:Depends}
dpkg-gencontrol: warning: Depends field of package libjbig2enc-dev:
unknown substitution variable ${shlibs:Depends}
In final packages I can't see anytihing about Python. Are you sure
that Python addons and depends are needed for this source?
Good lucky!
Regards,
Eriberto
2017-02-02 5:42 GMT-02:00 Rogério Brito <rbrito@ime.usp.br>:
> Dear mentors,
>
> I've been (re-)getting up to speed with my packaging skills and I have an
> scratch to itch. I would, therefore, kindly request your comments on the
> following package:
>
> - - - - - - - - - - - - - - - - - - - - - - - - -- - - - - - - - - - - -
>
> * Package name : jbig2enc
> Version : 0.28+git0693dcd-1
> Upstream Author : Adam Langley <agl@imperialviolet.org>
> * URL : https://github.com/agl/jbig2enc
> * License : Apache-2.0
> Section : graphics
>
> It builds those binary packages:
>
> jbig2enc - JBIG2 encoder
> libjbig2enc-dev - JBIG2 encoder (development files)
> libjbig2enc0 - JBIG2 encoder (shared library)
>
> To access further information about this package, please visit the
> following URL:
>
> https://mentors.debian.net/package/jbig2enc
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/j/jbig2enc/jbig2enc_0.28+git0693dcd-1.dsc
>
> I also maintain my changes in a repository in git-buildpackage form at:
>
> https://github.com/rbrito/pkg-jbig2enc
>
> More information about jbig2enc can be obtained from https://github.com/agl/jbig2enc.
>
> - - - - - - - - - - - - - - - - - - - - - - - - -- - - - - - - - - - - -
>
> Apart from lintian's binary-without-manpage/dh-make-template-in-source which
> are about a manpage for jbig2 (I still have to decide how to proceed in the
> best way with respect to this), are there any problems with the package?
>
> I do *not* consider this package yet ready for primetime, since I'm not sure
> what to do with the pdf.py script yet that it contains (it creates PDF files
> from jbig2-encoded files).
>
> The reason why I'm titling this to be a RFC instead of a RFS is because it's
> been a while since I last packaged a package that had a library and my
> packaging-fu regarding the last 5 or so years relative to libraries are
> starting to show up.
>
>
> Thanks in advance,
>
> Rogério Brito.
>
> --
> Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA
> http://rb.doesntexist.org/blog : Projects : https://github.com/rbrito/
> DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
>
Reply to: