First off, thanks for doing the work of preparing this package for Debian. I'd also like to apologize
for the long wait you've endured, and the lost opportunity for Stretch inclusion.
Your packaging is in pretty good shape. I have some comments based on a review, detailing the
changes I would like to see before uploading.
First, a couple of things which are not your fault - debhelper/compat should be 10 now, and there
is a newer upstream version released. When you add the new version, set the older changelog
entry to UNRELEASED.
The source tar you uploaded does not match upstream. I did not investigate why.
One thing I very much like to see is a get-orig-source target in rules. It is a good way to ensure that
the correct source tar is always included, and is close to plug-and-chug with the instructions on the
wiki page:
https://wiki.debian.org/onlyjob/get-orig-source
I'd also like to see an /etc/freight.conf installed, defining the defaults and providing an obvious location
to modify them.
As an aside, when I first looked at freight, I was intrigued by the prospect of managing repos with
no config file (-c /dev/null). Params are defined as shell variables, and there are only about three that I
care about. Life would be simpler if I could just define the variables and call the freight commands
from the same script. Alas, it is not coded to support that right now.
The package needs to work properly out of the box. That means ensuring that the default VARLIB and
VARCACHE default directories are established and created as a part of the install. I'm not going to put
my secret key under root - there needs to be a standard way to run as a normal user, perhaps
by establishing a group with the necessary default permissions, and a clear message from freight-add
telling the user how to get the proper access. So, create a freight user and group, make the group
able to work in the default directories, and prompt the user with the proper usermod command if write
access fails on those directories. Note that users are established using installation scripts,
and that any user created in an installation script is never deleted by same.
Both your deb and the deb from the upstream homepage failed for me in chmod pubring.gpg. The
work directory did not exist. I commented out all actions on pubring to continue.
I don't recall if freight-cache announces the repo directory on completion. It should.
The FTP Masters are sticklers for the copyright file. Yours captures everything from the source, but
also includes "The Freight Team", with no indication of how it is claimed upstream. I don't know if that
will cause problems or not.
Minor stuff
This is minor (i.e. not required by me), but the lib scripts should be in /usr/share/freight.
http://www.pathname.com/fhs/pub/fhs-2.3.html#USRSHAREARCHITECTUREINDEPENDENTDATA
Bash completion installation?
I promise a shorter wait next time.
--
AE0D BF5A 92A5 ADE4 9481 BA6F 8A31 71EF 3661 50CE
Attachment:
signature.asc
Description: GooPG digital signature