Bug#850607: RFS: flask-login/0.4.0-1 [ITA]
Control: tag -1 -moreinfo
Hi Sean,
Thanks for your second review.
- The package does not build against sid. See attached log.
I was having problems understanding how to setup a chroot build what with the
array of tools available: pdebuild, cowbuilder, etc. I see you're using sbuild
which I wasn't even aware of, so now I've installed and configured that. Thanks
for the pointer.
The build now succeeds with sbuild -A since I've added the missing B-Ds.
- Updates to d/clean not mentioned in changelog.
> - Edits to d/source/options
- Lots of changes to the build-deps not mentioned in changelog.
> - The new 0002 patch is not in the changelog.
> - doc-base registration not in changelog
> - Installation of README.md not in changelog
Added/adjusted changelog entries to cover all of these.
- It's odd for the -doc package to recommend the main package. See the
description of Recommends: in Debian policy -- the relationship is
quite strong, but someone might want to read the docs on their dev
machine and use the library on some container/server.
Ok, I wasn't really sure of the convention and I think the first random package
I checked had the asymmetrical relationship with its -doc package. I'll make it
a Suggests in both directions.
- Could you explain why you have three "override_dh_sphinxdoc"?
Possibly you're using some Makefile syntax I'm not familiar with.
Yes this is the syntax for specifying target-specific variables:
https://www.gnu.org/software/make/manual/html_node/Target_002dspecific.html
I based the rule on the DPMT wiki, which uses this syntax:
https://wiki.debian.org/Python/LibraryStyleGuide#Sphinx_documentation
If you're able to address the issues I've raised in this message,
please remove the moreinfo tag in this bug, and don't forget to
re-run `dch -r` to refresh the changelog timestamp.
Done! Uploaded to git and mentors, the diff since your last review is below.
Cheers,
Carl
$ git diff 57c7cc9
diff --git a/debian/changelog b/debian/changelog
index 33b9e0b..7c38769 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,20 +2,35 @@ flask-login (0.4.0-1) unstable; urgency=medium
* New upstream release.
* New maintainer (Closes: #836501).
- * Update d/compat to 10.
- * Switch to using dh-python.
+ * Update d/compat to 10 and raise B-D on debhelper accordingly.
+ * Switch to using dh-python:
+ - add B-D on dh-python.
* Add myself to d/copyright for debian/.
* Change d/watch to follow GitHub releases.
* Change homepage to GitHub.
- * Build the Python 3 module (Closes: #802614).
+ * Build the Python 3 module (Closes: #802614):
+ - replace B-Ds python{,3}-all and python{,3}-setuptools.
* Stop building the Python 2 module (no rdepends).
* Move Vcs to DPMT git.
* Bump standards version to 3.9.8 (no changes).
- * Build the documentation in a -doc package.
+ * Build the documentation in a -doc package:
+ - add B-D on python-sphinx,
+ - add links from the /usr/share/doc/python3-flask-login to
+ /user/share/doc/python3-flask-login-doc,
+ - register with doc-base,
+ - make the Python 3 module and -doc package Suggest each other.
+ * Install the upstream README file.
* Add 0001-disable-github-fork-ribbon.patch to turn off the GitHub ribbon.
- * Run the test suite using upstream's makefile.
+ * Add 0002-allow-choice-of-nosetests-executable-in-run-tests.sh.patch to
+ allow the tests to be run with nosetests3 for the Python 3 package.
+ * Run the test suite using upstream's makefile:
+ - add B-Ds on python3-flask, python3-mock, python3-nose, python3-werkzeug
+ and python3-blinker,
+ - cleanup tests_output/ and .coverage in d/clean.
+ * Use more general rule to ignore egg-info directory in d/clean and
+ d/source/options.
- -- Carl Suster <carl@contraflo.ws> Tue, 10 Jan 2017 15:23:33 +1100
+ -- Carl Suster <carl@contraflo.ws> Wed, 11 Jan 2017 14:23:07 +1100
flask-login (0.2.6-1) unstable; urgency=low
diff --git a/debian/control b/debian/control
index 5af8224..49d3948 100644
--- a/debian/control
+++ b/debian/control
@@ -6,12 +6,14 @@ Priority: optional
Build-Depends:
debhelper (>= 10),
dh-python,
- python-flask,
python-sphinx,
python3-all,
python3-blinker,
+ python3-flask,
+ python3-mock,
python3-nose,
python3-setuptools,
+ python3-werkzeug,
Standards-Version: 3.9.8
Homepage: https://github.com/maxcountryman/flask-login
X-Python3-Version: >= 3.3
@@ -38,7 +40,7 @@ Package: python3-flask-login-doc
Architecture: all
Section: doc
Depends: ${misc:Depends}, ${sphinxdoc:Depends}
-Recommends: python3-flask-login
+Suggests: python3-flask-login
Description: user session management for Flask -- documentation
Flask-Login provides user session management for Flask. It handles the
common tasks of logging in, logging out, and remembering your users'
Reply to: