Bug#844765: RFS: gitless/0.8.4-1 -- new package

[Andreas Henriksson <andreas@fatal.se>]

Hello Peter Pentchev,

On Fri, Nov 18, 2016 at 10:15:20PM +0200, Peter Pentchev wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for the initial upload of my package
> "gitless" - a version control system on top of Git.
[...]

I've looked over your new package sources (not built it yet).
I have some comments of which (only) the first one is something
I consider a blocker for uploading it.....

# debian/copyright and contradicting licensing.

While the LICENSE.md file (and debian/copyright) claims the
software is licensed under GPLv2+, when looking at the
actual gitless/*.py files the header says GPLv2 (only).

This contradiction might be something the debian ftp-masters has a
problem with. I'd suggest you discuss it with upstream and suggest that
if GPLv2+ is the intended license the headers are updated to clarify
that. Please use the standard boilerplate in the file headers!

See "How to Apply These Terms to Your New Programs" in LICENSE.md

# manpage

Please consider upstreaming it if you haven't already.

# debian/patches/pager.patch

Please consider using 'sensible-pager' before falling back on 'less'.
(Also while less is usually preferred over more, I think more would be a
more commonly available and thus better as a last resort fallback. On
debian sensible-utils is Essential:yes so always available which means
discussing any fallback after it is quite theoretical.)

# debian/patches/python3.patch

Why is forwarding it not-needed?

# debian/tests/control

This isn't my area of expertise, but do you really need to depend on
things which your package already depends on for the test environment?


Everything else looks super tidy to me.

HTH.

Regards,
Andreas Henriksson