[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#849918: RFS: tinymux/2.10.1.13-1



Thanks for the starting point. I had worked out the d/watch file enough that it works locally (mentors.debian.net still complains), but I like your wildcards better, so I'm using that one (mentors.debian.net still complains). The simple short d/rules is very much appreciated. I only just begin to discover the override_* stuff before you sent it. You saved me two days there. That and writing d/install and d/clean exposed some embarrassing stray symbolic links. I actually prefer enumerating the exact placement of all the files. So, what remains:

 - I think the fortify complaint about slave and stubslave is probably because they are so minimal. I don't think they use any libc functions actually.
 - There's no obvious override for the duplicate changelog warning.
 - Revisit d/changelog to make sure the package changes are fully captured.
 - It would be nice to get make -j2 working. They did work once upon a time. Might be better to fix that upstream.
 - Test. The prettiest package in the world doesn't necessarily install anything that works.

On Wed, Jan 4, 2017 at 4:32 PM, Tobias Frost <tobi@debian.org> wrote:
Am Donnerstag, den 05.01.2017, 00:24 +0100 schrieb Tobias Frost:
>
> I wrote you a rule file as starting point. Attached. It is thought to
> get you started. 
> (Some parts are missing, like the hardening; also stuff and you need
> to
> do outside of the rules, like to create the file d/clean with all
> files
> listed and d/install to to put the files actually in place
>
PS: I needed to add --no-parallel because parallel build is broken
here. This is also bug in your Makefile...

To trigger
#debuild -j1
(works)

#debuild -j4
(...)
g++ -g -O2 -fdebug-prefix-
map=/home/tobi/workspace/deb/mentors/Jan03/tinymux-2.10.1.13=. -fstack-
protector-strong -Wformat -Werror=format-security -Wall -O3 -fomit-
frame-pointer -Wdate-time -D_FORTIFY_SOURCE=2 -g -O     -
DSTUB_SLAVE       -Wl,-z,relro -Wl,-z,now -o stubslave stubslave.o -L.
-lm -lcrypt   -lmux 
/usr/bin/ld: cannot find -lmux
collect2: error: ld returned 1 exit status
Makefile:189: recipe for target 'stubslave' failed
make[1]: *** [stubslave] Error 1
make[1]: *** Waiting for unfinished jobs....
( if [ -f netmux ]; then mv -f netmux netmux~ ; fi )
g++ -g -O2 -fdebug-prefix-
map=/home/tobi/workspace/deb/mentors/Jan03/tinymux-2.10.1.13=. -fstack-
protector-strong -Wformat -Werror=format-security -Wall -O3 -fomit-
frame-pointer -Wdate-time -D_FORTIFY_SOURCE=2 -g -O     -
DSTUB_SLAVE       -Wl,-z,relro -Wl,-z,now -o netmux _build.o alarm.o
alloc.o attrcache.o boolexp.o bsd.o command.o comsys.o conf.o cque.o
create.o db.o db_rw.o eval.o file_c.o flags.o funceval.o funceval2.o
functions.o funmath.o game.o help.o htab.o local.o log.o look.o mail.o
match.o mathutil.o mguests.o modules.o move.o muxcli.o netcommon.o
object.o predicates.o player.o player_c.o plusemail.o powers.o quota.o
rob.o pcre.o set.o sha1.o speech.o stringutil.o strtod.o svdrand.o
svdhash.o timer.o timeabsolute.o timedelta.o timeparser.o timeutil.o
timezone.o unparse.o utf8tables.o vattr.o walkdb.o wild.o
wiz.o  version.o -L. -lm -lcrypt     -lmux
/usr/bin/ld: cannot find -lmux
collect2: error: ld returned 1 exit status
Makefile:198: recipe for target 'netmux' failed
make[1]: *** [netmux] Error 1
make[1]: Leaving directory
'/home/tobi/workspace/deb/mentors/Jan03/tinymux-2.10.1.13/src'


Reply to: