control: tag -1 +moreinfo
Hello Jörg,
On Sun, Jan 01, 2017 at 11:12:48PM +0100, Jörg Frings-Fürst wrote:
> Am Sonntag, den 01.01.2017, 20:43 +0000 schrieb Sean Whitton:
> > [Jörg's address bounced from my MTA so re-sending to -submitter; sorry
> > for noise]
> I look tomorrow morning why your mail was bounced.
Thanks!
> Sorry that I misinterpret this:
> [...]
You didn't :) I was wrong.
Great work with the package split, and rewriting the package
description. Some minor remaining issues:
(1) There are some typos in NEWS.Debian. s/dems/demos/ s/und/and/
(2) You added "[ Team Upload ]" to the changelog. But this is not a
team upload, because you are in the Maintainer: field. Please remove
the "[ Team Upload ]".
(3) You indicated in d/copyright that Mike Gabriel has 2017 copyright.
But he didn't make any changes this year.
(4) In the changelog you wrote
debian/rules: Remove the documentation from /usr/share/xtrkcad.
But it wasn't d/rules that you edited to do this! I think you just need
to drop that line.
(5) Since you moved the docs, the Help->Contents menu option doesn't
work. I think you need to add a patch (Forwarded: not-needed).
Some optional suggestions:
(1) You wrote "Remove not used Build-Depends." -- it might be useful to
list the ones you removed in the changelog. Your choice.
(2) The HTML docs are quite large. How about moving them into -common?
As before, once you've made further changes, please remove the moreinfo
tag from this bug and don't forget to re-run `dch -r`.
Detailed replies to older mail:
On Fri, Dec 30, 2016 at 05:15:13PM +0100, Jörg Frings-Fürst wrote:
> I have change
>
> * BSD-Revised to BSD-1-Clause
> * mixed to BSD-like-with-advertising-clause
>
> permissive I have found at[1], but also a lot of other license text
> with the same name. So I ask debian-legal[2].
Thanks for doing that. Looks fine now.
> >
> > - if you run `licensecheck --copyright -r .` you will find many files
> > that are Copyright 2005 David Bullis. Maybe you should add this to
> > the "Files: *" stanza?
> >
> > - Mikko Nissinen also holds copyright on app/i18n/stripmsg.c
> >
> > - copyright years for getopt.*, uthash.h, gwin32.c, mswbitmap.c and
> > others are wrong -- why did you add '-2015' when the file was not
> > edited since the earlier year?
> >
> I have used the file modification time.
Ah. Generally the file modification time is too flimsy for this
purpose. Thanks for changing it back.
> > - copyright for app/tools/halibut/charset/macenc.c wrong
> >
>
> I have checked and changed:
>
> * Add David Bullis to Files: * and remove the stanzas with only him as
> copyright holder.
> * Use only the year(s) written into the files.
> * Add missing stanzas.
LGTM.
> > > I have add a new patch 0900-spelling-errors.patch to correct the
> > > spelling error.
> >
> > Thanks, and great work forwarding the patch.
> >
> Normally. Or?
Yes, it should be normal to forward it, but not all sponsees do it.
> > > > It looks like you used wrap-and-sort -- please add this to the
> > > > changelog, so a future contributor knows which options to use.
> > > > E.g.
> > > >
> > > > * Run wrap-and-sort -abst
> >
> > You haven't added this to the changelog yet...
>
> I don't use this tool..
Okay, fine.
> >
> > > >
> > > > You made changes to d/rules not documented in the changelog.
> > >
> > > sry. Also I don't have a git commit message. I have add a comment about
> > > this.
> >
> > What do you mean about "git commit message"?
> >
> > Changelog for d/rules LGTM.
> >
> For me is one of the last work to check all lines of the changelog vs.
> the git commit messages for missing parts.
>
> Comment added.
Just fyi, the git commit style is your choice as maintainer. All I care
about is the changelog (which can be less detailed than git commit
history, generally).
>
> And for your 2. mail:
>
> I have moved the html directroy, Readme.txt and logo.bmp to
> /usr/share/doc/xtrkcad.
>
>
> The other directories (demo, examples, params) contains only data file.
> I think that /usr/share/xtrkcad is the right place for them. Especially
> if we want to move the data into a new package in the future.
Fine.
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature