On 2016-12-13 07:59+1100, Dmitry Smirnov wrote: > On Monday, 12 December 2016 11:09:56 AM AEDT Félix Sipma wrote: >> From gbp-dch(1): >> >> --id-length=N >> Include N digits of the commit id in the >> changelog entry. Default is to not include >> any commit ids at all. >> >> So, that's already the default, right? It could be modified by the user's >> global gbp.conf, and it affects the changelog entries, so I set it back to >> this. > > Yes, I don't want commit IDs in changelog so I explicitly state that. I've > started doing so after few cases when uploaders introduced needless commit ID > noise to changelog. > >>> Basically it instructs GBP to generate/use tarball and it might be useful >>> for "debian"-only master repository layout. I reverted this. >> I thinks that these should be set by the user's global gbp.conf. > > I also think so. Personally I don't build packages with GBP so I shouldn't > care much but this fragment may be important for thouse who don't know how to > build package without upstream sources in master. This fragment was > introduced after earlier discussion in mail list when someone suggested that > repository layout should be compatible with GBP either through "standard" > layout or with gbp.conf to allow package build out of the box. > >> If he >> wants to use "export-dir = ../debian-build-area" or anything else, we >> shouldn't override this. > > I agree this is ugly but "export-dir" is important because one can't build > package with default settings. It is always easier to change existing > settings than try to find which parameter should be added. > >> Does this address your concerns? > > Nope. :) But those concerns wasn't really mine as it is all about helping > those who build packages with GBP... I get your point, but I think we should not set this in every package using gbp. If there is a bug in gbp, it should be reported, and not hidden by workarounds :-). In the meantime people may have to set a minimum configuration in their global gbp.conf. If you don't care much about this, I'll prefer to let the package as it is now. Thanks again for your reviews!
Attachment:
signature.asc
Description: PGP signature