[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#836381: RFS: couchapp/1.0.2+dfsg1-1



On Fri, Sep 02, 2016 at 03:23:58 +0000, Gianfranco Costamagna wrote:
> control: owner -1 !
> control: tags -1 moreinfo
> 
> Hi,
> 
> >I'm looking for an sponsor for my updated package couchapp
> 
> 
> some questions before sponsoring or giving you DM
> 
> 1)
> 
> INSTALL_REQUIRES = ['restkit==4.2.2', 'watchdog==0.6.0']
> 
> 
> why is restkit manually listed in runtime dependencies?

that's for setuptools, I could patch it out, but why?

> 
> 2) 
> Vcs-Git: https://anonscm.debian.org/cgit/collab-maint/couchapp.git
> 
> 
> cgit is wrong for Vcs-Git :)

no, is not wrong
$ git clone
https://anonscm.debian.org/cgit/collab-maint/couchapp.git
Cloning into 'couchapp'...
remote: Counting objects: 7239, done.
remote: Compressing objects: 100% (2726/2726), done.
remote: Total 7239 (delta 4007), reused 7169 (delta 3955)
Receiving objects: 100% (7239/7239), 5.61 MiB | 942.00 KiB/s, done.
Resolving deltas: 100% (4007/4007), done.
Checking connectivity... done.


> 
> 3) this release seems to be Python3 ready, did you consider checking
> if all the dependencies are Python3 ready and switching to it?
> (note: I didn't check)

restkit doest not have a python3 package, nose-testconfig does not work on
python3 AFAIK, and it is necesary for tests

the mention in README.md about python3 is to host the coverage
reports

> 
> 4)
> +# Sample script to install Python and pip under Windows
> +# Authors: Olivier Grisel, Jonathan Helmus and Kyle Kastner
> +# License: CC0 1.0 Universal: http://creativecommons.org/publicdomain/zero/1.0/
> 
> +::
> +:: Author: Olivier Grisel
> +:: License: CC0 1.0 Universal: http://creativecommons.org/publicdomain/zero/1.0/
> 
> 
> showstopper!

thanks, how did you find it? licensecheck didn't!

PS: I've added autopkgtest support to the package :)

--
1AE0 322E B8F7 4717 BDEA BF1D 44BB 1BA7 9F6C 6333

keybase: https://keybase.io/gfa

Attachment: signature.asc
Description: PGP signature


Reply to: