Bug#829520: RFS: mbpfan/1.9.1-1 ITP
Hello,
On Tue, Aug 30, 2016 at 12:05:51AM -0700, Herminio Hernandez Jr wrote:
> > 5. You have lots and lots of patches without proper patch headers. The
> > patches seem to be revisions of each other. You need one patch for each
> > meaningful change, with the reason for the change explained in the patch
> > header (ideally a DEP-3-compatible header).
> >
> I am aware of this. I have been trying to figure out how to merge these patches. Any suggestions would be appreciated.
You can use gbp-pq(1) to convert the patches to a git branch, and then
use an interactive rebase to merge them.
Or there is combinediff(1).
> > 6. You shouldn't patch the makefile's install target. Override
> > dh_auto_install to disable it, and use dh_install to install the
> > files where they should go. (See the manpages for those tools.)
> >
> I will look into this. I did put in a pull request upstream with my Makefile changes and I believe it will be merged.
Great -- as I said, remove the moreinfo tag from the bug when you think
it's ready for another review.
--
Sean Whitton
Reply to: