Bug#830569: RFS: z3/4.4.1-0.1 [NMU] [4xRC]
Hi Fabian!
I don't intend to sponsor this upload, but here's a quick review:
* Fabian Wolff <fabi.wolff@arcor.de>, 2016-07-09, 16:14:
* Add patch fix-dotnet-version.patch (Closes: #808695).
This gives me no clue what the patch is about.
* Upgrade to Standards version 3.9.8 (no changes).
I don't think this is a good idea for an NMU.
* Install shared libraries into new libz3-4 package (Closes: #819884).
Now that the -dev package doesn't ship any ELFs, you should remove
${shlib:Depends} from -dev's Depends.
"Pre-Depends: ${misc:Pre-Depends}" should be moved to the shared library
package, or removed completely, because it's not needed these days.
* Install python files directly into /usr/lib/python2.7/dist-packages/
AFAICS, upstream build system installs these files in the right place,
so there should be no need to pick the *.py files from src/.
These d/rules lines are effectively no-ops and should be removed:
mkdir -p debian/tmp/usr/lib/python2.7/dist-packages/z3
touch debian/tmp/usr/lib/python2.7/dist-packages/z3/__init__.py
(The latter is probably a failed attempt of fixing #791604, which looks
like a previous incarnation #819884.)
* Remove unnecessary version restriction of build dependency
cli-common-dev.
Hmm, I don't know anything about CLI, but dh_cligacpolicy disagrees:
dh_cligacpolicy: Warning! No Build-Depends(-Indep) on cli-common-dev (>= 0.5.7)!
* Format debian/control with cme.
I don't think cosmetic changes are good idea for an NMU.
* Disable tests as they fail eventually.
All the tests? :-O
I've tried building z3 with hardening flags turned on, but the build
failed.
What was the error message?
I don't know what the problem with the -dev package is; contrary to
what Lintian claims, it *does* contain a symlink to the respective
shared library.
Yes, it does look like a bug in Lintian. Apparently it gets confused by
the -ocaml-dev package:
$ lintian libz3-4_4.4.1-0.1_amd64.deb libz3-dev_4.4.1-0.1_amd64.deb
[nothing]
$ lintian libz3-4_4.4.1-0.1_amd64.deb libz3-dev_4.4.1-0.1_amd64.deb libz3-ocaml-dev_4.4.1-0.1_amd64.deb
W: libz3-4: dev-pkg-without-shlib-symlink usr/lib/x86_64-linux-gnu/libz3.so.4 usr/lib/x86_64-linux-gnu/libz3.so
W: libz3-ocaml-dev: hardening-no-relro usr/lib/ocaml/z3/dllz3ml.so
There are a few other issues that I was not able to fix, but I think
closing the four RC bugs has a higher priority right now.
Absolutely. It's not NMUer obligation to fix every known bug.
--
Jakub Wilk
Reply to: