[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826974: RFS: moka-icon-theme/5.3.2-1 ITP



Thanks Adam,

  a new upload has been made. linitian runs now without any errors.

vcs-git and vcs-browser now points to the budgie-remix github repo where the debian source package resides.

GPL-3 points to the debian folder location

Description of moka has been made more descriptive.

rules file has been simplified

I'm not sure why I'm getting an information linitian issue on mentors for the vcs-git - all the examples I've seen say that vcs-git should be git:// ... but that linitian tag description says I should be using https:// - strange.

vcs-field-uses-insecure-uri


Think you are right about other packages.  KDE breeze-icon-theme has logos for a similar set of apps as moka.

I know the reason for the popularity of Moka is that it provides a consistent look across all displayed interfaces such as menus.  It  would be a great if the hard-work of the upstream maintainer could be made more readily available across the wider Debian community.

thanks

David

On 21 June 2016 at 05:06, Adam Borowski <kilobyte@angband.pl> wrote:
Control: owner -1 !
Control: tags -1 +moreinfo

On Fri, Jun 10, 2016 at 08:18:12PM +0100, foss.freedom wrote:
>   I am looking for a sponsor for my package "moka-icon-theme"
>
>  * Package name    : moka-icon-theme
>    Version         : 5.3.2-1
>
>     moka-icon-theme - Moka Icon Theme

First, please run lintian on the package.  It currently returns:
E: moka-icon-theme: copyright-should-refer-to-common-license-file-for-gpl
E: moka-icon-theme: description-is-pkg-name Moka Icon Theme

The Vcs-Browser needs to point to a VCS of the packaging rather than the
upstream code.  The VCS might contain just the debian/ dir or everything
-- a ready-to-build source package.  If you haven't used git for packaging,
please delete the field.

debian/rules contains:
override_dh_auto_install:
    --sourcedir=Moka
which has no effect.  Not sure what you intended to do here; this paragraph
can be safely deleted.


>From minute differences I noticed in a few places, I see logos included in
this package were drawn by hand by the author rather than copied exactly.
However, they are still derived from the originals.  Copying by wetware is
still copying.  This package includes a massive number of icons for various
software and companies, both free and non-free.  I'm not sure what the exact
rules are: faenza was forced to remove most logos, yet I see those in a
number of other packages.  I guess it's up to ftpmasters to decide.

Meow!
--
An imaginary friend squared is a real enemy.


Reply to: