Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Gianfranco Costamagna <locutusofborg@debian.org>]

control: owner -1 !
control: tags -1 moreinfo

Hi, lets see

1) control: why the -dev package is not multiarch?
sounds like it is multiarch ready to me
(I didn't check but include/* seems to have the same md5sum on different archs


2) the dev package should suggest the doc one


3) d/p/0002-fix-build-with-static-libcheck-library.patch

I can't complain here, I seem to know the author of that patch :p


3) d/p/0004-remove-test-of-python-cram.patch

why? python-cram is available on Debian

4) d/p/0007-*
why? please be more verbose on patches, otherwise I find difficult to understand why you are using sphinx instead
of pandoc to build documentation

5) rules:
I don't like hacks
and your sed makes the package non-rebuildable.

maybe overriding the 

dh_install target, and acting under debian/libfoo-dev/usr/include 

is a "better" way (also, a mv instead of ln -s since this old directory should go away)

--buildsystem=cmake --builddirectory=build should be useless


also
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/buildflags.mk


6) did you forward the rename to upstream?

7) libredjackipset-docs.docs
is it useful? there is no package with that name, so probably the file can be removed

8) I'm not a fan of dh-exec, and your patch about multiarch seems incomplete

+include(GNUInstallDirs)

this has to be done *before*

"set(CMAKE_INSTALL_LIBDIR lib${LIB_SUFFIX} CACHE STRING"
note the LIB_SUFFIX

and then the install files can change from
usr/lib/lib*.so usr/lib/${DEB_HOST_MULTIARCH}
to
usr/lib/*/*.so
and similar for others

9)

did you try compat level 10?
it should speed up the build by running dh --parallel :)
(you can also experiment with --parallel on the default dh call in rules file)

I guess that's all for now :)

Gianfranco