Bug#826134: RFS: libvpd/2.2.5-1 ITP: libvpd -- VPD Database access library
Hi,
I did new upload right there :
https://mentors.debian.net/package/libvpd
https://mentors.debian.net/debian/pool/main/libv/libvpd/libvpd_2.2.5-1.dsc
> lets see:
>
> usr/include/libvpd-2/*
> usr/lib/*/*.so
> usr/lib/*/pkgconfig/*
>
> maybe you can put
> usr/include
> usr/lib/*/*.so
> usr/lib/*/pkgconfig
>
> (I didn't check the above)
done
That works. And I changed to this in the new packaging.
For usr/include/libvpd-2/* -> usr/include
I initially used that "generic" regexps but I wondered and prefered more
targetted regexps to avoid copying files that were wrongly installed in that
path, in case of a later upstream version.
Meaning that the idea was that I see things failing and fix it, or extend the regexp
if that's correct, but don't put things blindly in that path.
However, I used usr/include in the packaging.
> and for the library you can do something like
> usr/lib/*/lib*.so.*
done
> "etc/udev/rules.d/90-vpdupdate.rules /lib/udev/rules.d"
> isn't this something that dh_installudev should do?
done
right, I didn't see there was also a dh_installbla for udev at that time :)
> rules file has a lot of useless stuff (comments, dh_options)
done
> d/patches: remove
done
> missing licenses:
> config/install-sh: MIT/X11 (BSD like)
> config/missing: GPL (v2 or later) GENERATED FILE
> config/ar-lib: GPL (v2 or later) GENERATED FILE
> config/depcomp: GPL (v2 or later) GENERATED FILE
> config/ltmain.sh: GPL (v2 or later)
done
Actually, for the last 4, the embedded license says :
---
As a special exception to the GNU General Public License, if you
distribute this file as part of a program that contains a
configuration script generated by Autoconf, you may include it under
the same distribution terms that you use for the rest of that program.
---
Does that mean that it could be distributed with the global license of the
project? And maybe needn't being explictly listed in d/copyright ?
Anyway, I added those files as well as config.guess, config.sub, aclocal.m4,
Makefile.in and configure with their specific Copyright and License, just in
case.
> debian/copyright: LGPL (v2.1 or later)
>
> wrong copyright:
> License: LGPL-2+
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU Lesser General Public License as published
> by the Free Software Foundation; either version 2.1, or (at your option)
>
>
> 2+!=2.1+
done
Indeed, I missed something here.
> other stuff LGTM
On the lintian side, here is what remains :
P: libvpd source: debian-watch-may-check-gpg-signature
I: libvpd-2.2-2: spelling-error-in-binary usr/lib/powerpc64le-linux-gnu/libvpd_cxx-2.2.so.2.2.5 occured occurred
W: libvpd-2.2-2: dev-pkg-without-shlib-symlink usr/lib/powerpc64le-linux-gnu/libvpd-2.2.so.2.2.5 usr/lib/powerpc64le-linux-gnu/libvpd-2.2.so
W: libvpd-2.2-2: dev-pkg-without-shlib-symlink usr/lib/powerpc64le-linux-gnu/libvpd_cxx-2.2.so.2.2.5 usr/lib/powerpc64le-linux-gnu/libvpd_cxx-2.2.so
For the last 2, I think lintian gets lost with .so that are differently named :
lrwxrwxrwx root/root 0 2016-06-06 15:44 ./usr/lib/powerpc64le-linux-gnu/libvpd.so -> libvpd-2.2.so.2.2.5
lrwxrwxrwx root/root 0 2016-06-06 15:44 ./usr/lib/powerpc64le-linux-gnu/libvpd_cxx.so -> libvpd_cxx-2.2.so.2.2.5
F.
Reply to: