Bug#821236: RFS: netsed/1.2-2
Hi Mats,
I've reviewed your package. It's in a good state, but there's a few
things you might wanna take a look at:
* debian/control:
- Is "dpkg-dev" really a dependency?
- Please run "wrap-and-sort -a" to sort the build dependencies.
- The URL in "Vcs-Browser" can be the same as "Vcs-Git". The newer
(in Vcs-Git) is much better to use in a browser than the "gitweb" one.
* debian/copyright: please take a look at the copyright years. For
instance, yours is defined as "2010" in there, but looking at the
changelog it should be something like "2011-2016"?
* debian/docs: are you sure the "TODO" file should be part of the
package? It looks like documentation for developers, not end-users.
* debian/patches/series: empty file that should be removed.
* debian/rules:
- debhelper compatibility was raised to 9, but there are comments in
there referencing the changes made to support the version 8 that
should be removed.
- "export CPPFLAGS CFLAGS LDFLAGS" and those variable definitions
should be removed.
- Hardening should be added with "export DEB_BUILD_MAINT_OPTIONS =
hardening=+all". This will fix "hardening-no-pie" and
"hardening-no-bindnow" lintian complaints.
* debian/watch: is not working, yelding an error "1.sig failed: 400 URL
must be absolute". Changing "\1" to "$1" in
"opts=pgpsigurlmangle=s|(.*).tar.gz$|\1.sig|" allows the signature to
be downloaded, but uscan fails to check it with "uscan warn: FAIL
Checking OpenPGP signature (no upstream tarball downloaded)." Are you
sure the key in "debian/upstream/signing-key.asc" is right?
Please let me know if you have doubts with any of these points.
Regards,
Tiago.
--
Tiago "Myhro" Ilieve
Blog: https://blog.myhro.info/
GitHub: https://github.com/myhro
LinkedIn: https://br.linkedin.com/in/myhro
Montes Claros - MG, Brasil
Reply to: