On 13/04/16 18:22, Gianfranco Costamagna wrote: > control: owner -1 ! > control: tags -1 moreinfo > > Hi Chris > >> I am looking for a sponsor to update the python-django-feincms package. >> The package has 3 RC bugs, the earliest dating back to June 2014 (nearly >> a year). >> > > before uploading I have some issues to raise. > > first python-django-tagging needs to be fixed. I see the fix is already on git (you > did the import), so with this mail I'm contacting both maintainers to see if they > want to upload it. I've now filed #821220 against sponsorship-requests for python-django-tagging. > Well, there is also a new changelog entry about fixing VCS fields, you should > really merge in the previous one, since it never hit unstable. Done. > that said, please fix before the tagging package, and then we will look at this one > > https://launchpadlibrarian.net/165738145/python-django-feincms_1.7.4-1_1.7.4-1ubuntu1.diff.gz > what about this patch? I removed the patched line in this commit [1], with the reasoning that after the update to the new version, the file for which the permissions are being changed, no longer exists. 1: https://anonscm.debian.org/cgit/python-modules/packages/python-django-feincms.git/commit/?id=835fc3c05636254d546e8ea99fd8d8a6692f2038 > please note: I didn't do a full review, lets wait some time for maintainers to react, and > then I'll be happy to sponsor the packages in the correct order (-tagging and then -feincms). Great, thanks :)
Attachment:
signature.asc
Description: OpenPGP digital signature