Bug#817005: RFS: aseqjoy/0.0.1-1 [ITP]
El 06/04/16 a las 05:24, Gianfranco Costamagna escribió:
> control: owner -1 !
> control: tags -1 moreinfo
>
> Hi, lets review:
>
> check-all-the-things review:
> Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata
>
>
Added! (i'm not sure if need i to add more fields.)
>
> debian/copyright: please use the same upstream license, and for Debian packaging
>
> LGPL-2.1 seems unfeasible anyway (I think I read that LGPL is for libraries)
Fixed. Is possible to have upstream => gpl2 and debian/* => gpl3, true?
>
> Standards-Version: 3.9.6 --> 3.9.7 now
Fixed.
>
> please run autoreconf.
> (dh --with autoreconf, and a dependency on control file)
>
Fixed.
>
> the other stuff LGTM, but I didn't run lintian and a build yet
>
> (I'll do when you fix the above)
>
> cheers,
>
> G.
>
Thanks for your review, i just upload to mentors with these fixes.
Saludos!
--
Fernando Toledo
Dock Sud BBS
http://bbs.docksud.com.ar
telnet://bbs.docksud.com.ar
Reply to: