[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#807432: marked as done (RFS: python-jellyfish/0.5.3-1 [ITP])

Your message dated Sat, 9 Apr 2016 17:45:11 +0000 (UTC)
with message-id <1999355180.3462797.1460223911269.JavaMail.yahoo@mail.yahoo.com>
and subject line Re: Bug#807432: RFS: python-jellyfish/0.5.1-1 [ITP]
has caused the Debian Bug report #807432,
regarding RFS: python-jellyfish/0.5.3-1 [ITP]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
807432: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807432
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "python-jellyfish"

* Package name    : python-jellyfish
  Version         : 0.5.1-1
  Upstream Author : James Turk <james.p.turk@gmail.com>
* URL             : https://github.com/jamesturk/jellyfish
* License         : BSD-2-clause
  Section         : python

It builds those binary packages:

python-jellyfish - Library for approximate and phonetic matching of strings (Python 2)
python-jellyfish-doc - Library for approximate and phonetic matching of strings (documentation)
python3-jellyfish - Library for approximate and phonetic matching of strings (Python 3)

To access further information about this package, please visit the following URL:

http://mentors.debian.net/package/python-jellyfish


Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/p/python-jellyfish/python-jellyfish_0.5.1-1.dsc

More information about python-jellyfish can be obtained from https://github.com/jamesturk/jellyfish.

Regards,
 Diego M. Rodriguez

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Hi Victor


>pep8 is solely checking against the PEP-8 Python style guide. It is
>not in any way useful to have Debian patches for changing the style.
>cats only runs pep8 so people ask upstream to make their code more
>readable via PEP-8, but the style used by upstream is completely up to
>them.

Completely exact, there is no real gain from maintaining a downstream patch
for this.

to sum-up:
I was *completely* satisfied with your answers.

I changed the target to unstable, bumped std-version to 3.9.8 (it got bumped
after my previous review), and uploaded on unstable.

Just a question:
the code in README file, works for python3 but not for python.
However I think its a README fault, not a code fault.
python
>>> import jellyfish
>>> jellyfish.levenshtein_distance('jellyfish', 'smellyfish')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "jellyfish/_jellyfish.py", line 13, in levenshtein_distance
raise TypeError(_no_bytes_err)
TypeError: expected unicode, got str


while
jellyfish.levenshtein_distance(u'jellyfish', u'smellyfish')
2


works.

thanks for your contribution to Debian! (and please ask upstream to fix the README!)

--- End Message ---
Reply to: