Hi Gianfranco, thanks for the RFS :) First, some info: Upstream released python-neovim-gui_0.1.2. That depends on python-neovim >= 0.1.6, which I already have packaged and not uploaded, since python-neovim depends on neovim >= 0.1.3, currently unreleased git master branch, which is changing. We could send the tagged python-neovim-gui_0.1.1 to NEW, as it works with Debian's neovim_0.1.2 and python-neovim_0.1.2, but this version has some quirks that I would like to be fixed prior to shipping it. [1] Therefore, I have imported the new upstream version 0.1.2, which fixes some of the problems on the review, but we can't ship until we have neovim_0.1.3. On 06/04/16 13:22, Gianfranco Costamagna wrote: > control: owner -1 ! > control: tags -1 moreinfo > > Hi Victor, > > - please meld changelog in a single entry Fixed, removed Ondrej entry because if not it thinks it's an NMU. > install_requires = [ > 'neovim>=0.1.3', > 'click>=3.0', > 'pygobject' > ] > > please add them as build-dependencies and check that python3:Depends do its job Fixed. * Added neovim check. * python3-click is only present on testing and unstable as 6.2, I have added the check but it could be dropped. * pygobject is provided by python3-gi-cairo, python3-cairo, gir1.2-gtk-3.0 as jpleau and I tracked down [2][3]. > upstreaming the desktop file and the svg file is appreciated :) > (also installing it inside setup.py, to avoid overrides in debian packaging) Already upstreamed on 0.1.2. I haven't added the install inside setup.py since I wasn't sure it of the best way to make it work on all downstreams. > I usually prefer instead of a clean override something like > echo "neovim_gui/screen.c" >> debian/clean New version now ships a neovim_gui/screen.c. After a conversation at #debian-mentors and #python, Debian side I concur that we shouldn't be shipping it and that upstream should include the cythonize on the build, yet python docs say "distribute both .c and .py, don't build" [6]. I will leave the .c there for now. > does -pie breaks the build? why? > (link error? maybe adding some -l flags is enough?) Documented it on the commit message, please tell me if it's enough [4]. > check-all-the-things review: > pyflakes3 . Reported upstream, where I will tackle it [5]. Also, I now get an experimental lintian: X: python3-neovim-gui: library-package-name-for-application usr/bin/pynvim Should we rename the package as `pynvim` and move it to DPAT instead of DPMT, even if it is provided by PyPi's module `neovim-gui`? Cheers, [1]: https://github.com/neovim/python-gui/issues/16 [2]: https://github.com/neovim/python-gui/issues/5 [3]: https://anonscm.debian.org/cgit/python-modules/packages/python-neovim-gui.git/commit/?id=9bee986b0f35806517ae6d3dc7f2e882df95ef72 [4]: https://anonscm.debian.org/cgit/python-modules/packages/python-neovim-gui.git/commit/?id=e4f8f3de0874cc2c8f57a84f7fc182d23a1eed8a [5]: https://github.com/neovim/python-gui/issues/17 [6]: http://docs.cython.org/src/reference/compilation.html#distributing-cython-modules
Attachment:
signature.asc
Description: OpenPGP digital signature