Re: Bug#819681: RFS: python-django-gravatar2/1.4.0-1 [ITP]
Le jeudi 07 avril 2016 à 17:27:45+0200, Pierre-Elliott Bécue a écrit :
> Le jeudi 07 avril 2016 à 10:39:22-0300, Tiago Ilieve a écrit :
> > Hi Pierre-Elliott,
> >
> > On 7 April 2016 at 07:03, Pierre-Elliott Bécue <becue@crans.org> wrote:
> > > Dear mentors,
> > >
> > > So far it appears that I got no reply. I'm trying a small bump in hope that
> > > somebody will get interested because of my motivation, or that somebody that
> > > missed my first mail will see this one! :)
> >
> > I can't sponsor your package as I have no upload rights, but reviewed it:
>
> Thanks!
>
> > debian/control:
> > * Standards-Version: we are on 3.9.8 since yesterday;
>
> Saw that, will update
>
> > * Vcs-Git: there's no need for "-b master", as this is the default
> > branch anyway;
>
> You're right, but I'm an "explicit is better than implicit guy". :)
>
> > * ${shlibs:Depends} can be dropped from the "Depends:" field of each
> > binary package, as this isn't need for Python packages;
>
> True that.
>
> > * Architecture: "all" instead of "any" on each binary package.
>
> God, I can't believe I'm still doing that mistake.
>
> > debian/copyright:
> > * Copyright for Tristan Waddington is 2011-2015;
> > * Copyright for Pierre-Elliott Bécue is 2016;
> > * Why did you choose GPL-2+ for the packaging work? As said here
> > before[1], this can be a problem, as this license is more restrictive
> > than the upstream work, which is MIT.
>
> Ok for copyrights, I took the one from pypi. As for GPL-2+, It's a usual
> practice of me, will put MIT.
>
> > debian/rules:
> > * Please clean up the file a little, removing (most of) the commented lines;
>
> I thought it'd be better to keep them, but, okay.
>
> > * Add "export PYBUILD_NAME=django-gravatar2"[2]. That's the reason why
> > you probably ended up with empty binary packages and needed to add
> > custom "*.install" files.
>
> I'm not in fond of PYBUILD_NAME thing since I met a lot of trouble with it.
> If that's recommended I'll put it but I'm more a ".install" files guy.
>
> > python3-django-gravatar2.docs and python-django-gravatar2.docs:
> > * The preferred format for additional documentation is HTML (Debian
> > Policy Manual, § 12.4). If you want to ship the contents of the
> > "README.rst" file you probably want to do this after converting them
> > to HTML (e.g. using Sphinx).
>
> Will work on it this evening.
>
> > python3-django-gravatar2.install and python-django-gravatar2.install:
> > * Unneeded files that should be removed.
>
> See above.
>
> > Additional suggestions:
> >
> > * Please create a "debian/source/options"[3] file with
> > 'extend-diff-ignore="^[^/]+\.egg-info/"'. Otherwise you can't build
> > the package more than one time because dpkg-source will complain about
> > modified files.
>
> I do not have any issue to build multiple times, but I'll follow your
> advice.
>
> > * Is there a reason why you packaged the tarball from PyPI and not a
> > tarball from the upstream repository[4]? I'm asking this because
> > there's an override for "override_dh_auto_test" (avoiding it), when
> > the upstream repository contains tests that would be nice to bring to
> > the Debian package as well.
>
> I'm really uncomfortable with tests un packaging for python apps, but I can
> try to remove the override. Anyway, I'm using pybuild, hence the pypi
> package fits better and a good way to have a snapshot of upstream's work.
>
> > I hope this helps you to find a sponsor.
>
> Thank you very much for all these advice.
I uploaded a new version of the package. It should be visible soon, and
accessible also via
dget -x http://mentors.debian.net/debian/pool/main/p/python-django-gravatar2/python-django-gravatar2_1.4.0-2.dsc
--
PEB
Reply to: