[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#814921: RFS: sphde/1.1.0-1 [ITP] -- sphde -- Shared Persistent Heap Data Environment library



Hi Gianfranco,
thanks for your comments as usual,

> control: std-version is now 3.9.7

updated

> libjs-query can be left as-is, because using the internal debian jquery might result in a bad documentation
> package (look e.g. https://lists.debian.org/debian-devel/2014/10/msg00774.html";)
> this can simplify rules, control and so on

ok, I removed jquery related things (Depends in d/control and d/rules). Deep
issue actually.

> debian/*.manpages, you can remove the "debian/tmp" prepending path I think

surprisingly, I failed to do without. Maybe because dh_installman should be able to
take files in $CURDIR also ?

> copyright: is the debian directory under the same author as upstream?
> so you can avoid mentioning it.

Actually no. I put an Author field now, but I don't see that field in the
debian policy. Though I saw it used in several d/copyright browsing
sources.debian.net. Any tip ?

> package FTBFS on i386 and probably everywhere except amd64 (tested amd64, arm64 and i386 for now).

I did a patch in the package (already merged upstream) for i386 (missing
bracket in the source ..). It compiled on amd64, i386, ppc64el, powerpc. I'll
try to setup an arm qemu VM to check more.

> check-all-the-things:
> flawfinder -Q -c .
> [lots]

aw.. there's a bunch of flaws :)
I'm going to sensitize upstream about that. 

> codespell --quiet-level=3
> [lots]

I did a patch in the package and also submitted it upstream.

> some stuff autogenerated seems to be GPL-2 (check-all-the-things output)

I added config.sub and config.guess into d/copyright as they were distributed
in the source package indeed.

F.


Reply to: