[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#820196: RFS: dante/1.4.1+dfsg-1 -- new upstream version, packaging updates



control: owner -1 !
control: tags -1 moreinfo

Hi Peter,
changes are huge!


lets see:

some copyrights are missing
# Copyright (C) 1994 X Consortium
Radical Eye Software

Internet Software Consortium.


licensecheck * -r

 reports lots of missing licenses (BSD-4 as example)
while your "other" license might be considered a 

BSD-3-clause-like

please consider using the same license for Debian and Upstream, to ease patch forwarding
without having to relicense


please don't drop the NMU from <doko>
"dante (1.1.19.dfsg-3.1) unstable; urgency=medium"

+Standards-Version: 3.9.8 <-- we are on 3.9.7 now


+Package: dante-client <-- section oldlibs now?


changing symbols, doesn't break ABI? I think you have to bump SONAME


multiarch-find-lib <-- why?

I prefer autoreconf instead of autotools-dev

compat level 10? wow :)

dh_install
I prefer install instead of cp :)

as a side note: I don't understand why you overcomplicate stuff.
the upstream build system should know where to install stuff (multiarch and conf files)
if not, what about patching it?

the other stuff LGTM, please try to address at least some of the above points, and I'll sponsor it

please also consider merging the Ubuntu delta
https://launchpad.net/ubuntu/+source/dante/1.1.19.dfsg-3.1ubuntu1

cheers,

Gianfranco


Reply to: