control: owner -1 !
control: tags -1 moreinfo
Hi, lets review:
control:
please use autoreconf
std-version is 3.9.7
debian/menu: drop per ctte decision
copyright: lots of embedded libraries and copyright/licenses missing.
BSD / ISC / zlib/libpng / libpng / Apache?
not sure how many more, and with embedded libraries this is even worse.
automatic checks (check-all-the-things)
$ codespell --quiet-level=3
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'
# Parsing /proc/cpuinfo is not portable at all, use /sys instead.
$ grep -rF /proc/cpuinfo .
./JUCE/modules/juce_core/native/juce_linux_SystemStats.cpp: return getConfigFileValue ("/proc/cpuinfo", key);
$ flawfinder -Q -c .
(my eyes are bleeding now)
you need to fix a lot of stuff before getting this one into Debian
cheers,
G.
Attachment:
signature.asc
Description: OpenPGP digital signature