[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#813813: RFS: msi-keyboard -- command line tool to change MSI steelseries keyboards color setup



On 20/03/2016 22:37, Jakub Wilk wrote:
> * Giulio Paci <giuliopaci@gmail.com>, 2016-03-20, 03:05:
>>> I'm looking partly shocked at the commit
>>> 6fc1eec66c259cefeeb13453c3ceeb206fb24a55 why did you *substituted* the pristine-tar data?  You should always just add them.
>>
>> This is just because upstream never tagged a version, nor released a package.
>> I imported one using 0.0.1 version, but later noticed that 1.0 was set in the source and so I renamed the package.
> 
> Um. If upstream didn't make a release, then you ask them to make one, instead of declaring yourself that this random git snapshot will be called 1.0.
> 
> That the source says it's "1.0" is not very relevant, unless upstream bumps version in every commit; and they don't.

You are right. I wrote an email to Brad asking for a release.

> Also, you probably want to fix your debian/watch. :)

This for sure. Although steelskin is an interesting project as well... ;-)

Thank you for these comments.

Bests,
Giulio


Reply to: