On 20/03/16 04:26, Mattia Rizzolo wrote:
>> http://mentors.debian.net/debian/pool/main/d/django-prometheus/django-prometheus_1.0.6-1.dsc
>> It is also available on git.debian.org:
>> https://anonscm.debian.org/cgit/python-modules/packages/django-prometheus.git/
>
> DPMT package → ignoring mentors.d.n, just using the git repository
>
> * debian/control:
> + lack of VCS information, this is mandatory in the team.
> * debian/copyright:
> + please name the license "Apache-2.0"
> + <useless rant>why normal people don't put license and copyright on
> the header of the files?? :(</useless rant>
> * debian/rules:
> + you should be able to do that thing with the tests with pybuild
> tooling, like by using (untested)
> PYBUILD_TEST_ARGS="{interpreter} ./test/end2end/manage.py test --verbosity=2"
> note that you may also need to cp the tests or cd to {dir}.
> Please have a look at pybuild(1) and the wiki page
> https://wiki.debian.org/Python/Pybuild for more information
> + what's that notice about automatically generated file?
Thanks for the review, I have now made some changes which should fix the
above issues.
> Then, on github the newest tag is 1.0.5, but you are packaging 1.0.6,
> which makes me think you are not using github by pypi (checking... not
> even, the tarballs are different). Where did you get that tarball?
I got it from GitHub. I reminded the upstream maintainer to publish a
tag, and they have now done so.
Attachment:
signature.asc
Description: OpenPGP digital signature