[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#816004: RFS: [ITP] python-nameparser/0.3.11-1



Mattia Rizzolo <mattia@debian.org> wrote:
> control: owner -1 !
> control: tag -1 moreinfo
> 
> On Fri, Feb 26, 2016 at 03:34:02PM +0000, Edward Betts wrote:
> > I am looking for a sponsor for my package "python-nameparser"
> 
> ay.

Thanks for reviewing my package.

> * debian/changelog:
>   + you are closing two bugs; don't.
>     As the automated email from bartm (that definitely reached you, so
>     I'm wondering why yuo haven't done so yet) on #815972 says: "Please
>     retitle bug 735611 from RFP to ITP and set yourself as the owner."
>     After having done so, please remove #815972 from the changelog.

You're absolutely right. I realized this was wrong and made this change, but
I'd failed to upload a new version to mentors. This is now done. I've retitled
the bug and updated the owner.

> * dist/*:
>   + why on the earth is that directory filled with tarballs of old
>     releases?  Please ask upstream to stop shipping such tarballs, or
>     (maybe better), why not using the tarballs he's providing on pypi,
>     which seem to be nicer?
>     In that case please use http://pypi.debian.net/nameparser/watch

The tarball uploaded to pypi is missing the unit tests. These seems to be a
common problem with Python modules. The upstream developer feels like the
tests are only needed by people working on the code, not for the end user.
I think it is useful to run the tests when the Debian package is built and
possible have autopkgtest run the tests as well.

I will write to the upstream author and attempt to convince them that the
tests should be included in the pypi tarball. I tried this for the
django-jinja package, but upstream wasn't interested. Do you have any other
ideas, is there a way I could build the package from the pypi but included the
tests which are only in github?

> There is also a newer upstream, please package that.

Will do.

Thanks again,
-- 
Edward.


Reply to: