[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#816363: RFS: fgetty/0.7-0.1 [NMU] -- very small, efficient, console-only getty



Hi



>I knew what I did, but feel free to disagree with my reasoning.
>
>fgetty-login.diff essentially just renames /bin/login1 to /bin/fgetty-login.
<I find it confusing, when binaries are renamed. Either way, /bin/login{1,2}
>are never invoked directly, so I considered installing them into /lib/fgetty.
>It would eliminate need in manpage, which is barely useful. WDYT?


seems possible, having the upstream naming is also convenient to me.
Not sure about the rationale of the rename.

>ro-dev.diff demotes chown/chmod error, if it is caused by read-only
>/dev. I do not understand why anyone would want it, /dev is rw by
>default Debian installation. Yes, just tried, `getty' from util-linux
>issues warning, not error in case of ro /dev, but can anyone explain me
>why it is good thing?


it might not be the same on Debian derivatives, on chroots, on minimal
installations, on raspbian and so on.
in my opinion this one is still needed (and should be upstreamed).

I never had to mount /dev in ro, but I tried in a chroot and it seems possible.

Some particular installations might have this, for security or whatever else.

How do you feel about reverting?

>3 of 4 binaries are statically linked with no debug information.  So
>the only debug symbols for checkpassword(1). Since `$(wc -l
>checkpassword.c) = 93` I see little use of debug package.


ok, but shouldn't the new system provide "empty" debug packages then, or
maybe even better, understand and don't provide them?


>Sure. Will do better next time.


thanks! and thanks for the nice quality work!


Reply to: