Control: owner -1 ! Control: tag -1 + moreinfo On Fri, 11 Mar 2016 23:34:06 +0200, Nikos Tsipinakis wrote: Thanks for all your work, that's really exciting, and I'm happy to sponsor this upload. > On Fri, Mar 11, 2016 at 12:49:38AM +0100, gregor herrmann wrote: > > Will take a closer look tomorrow; a first look shows that the package > > might profit from some modernization (d/copyright in Copyright Format > > 1.0; > Done. The order of the paragraphs is a bit unusual; normally the "Files" sections come before the "License" sections. > > dh(1) in debian/rules; migration to new dbgsym packages (cf. > > dh_strip(1)'s --dbgsym-migration)), etc.). > Done. Cool. - I just think that the newsbeuter-dbg transition package should depend on newsbeuter-dbgsym instead of newsbeuter. (Or you can just drop it; I see the point but so far I haven't seen any other transition packages for debugging symbols; but it's fine for me to keep it.) > > I: newsbeuter: spelling-error-in-binary usr/bin/newsbeuter occured occurred > Sneaked this one in the translation-fix patch. Nice :) > > I: newsbeuter: hardening-no-fortify-functions usr/bin/newsbeuter > > I: newsbeuter: hardening-no-fortify-functions usr/bin/podbeuter > Fixed. Excellent! So alltogether there are no real blockers for me to upload this version; I'd just like to wait for you on a decision about the newsbeuter-dbg package, and if you want to keep it, to change the dependency to newsbeuter-dbgsym. A little reformatting of d/copyright would be nice but this is just aesthetical. And in the future, modernizing d/rules would be nice. Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Flying Pickets: Space Oddity
Attachment:
signature.asc
Description: Digital Signature