[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#816919: RFS: newsbeuter/2.9-1 [ITA]



Hello Dmitry,

On Tue, Mar 08, 2016 at 12:01:28PM +0300, Dmitry Bogatov wrote:
> [NO DD, can't sponsor]

Input is always appreciated :)

> There is nice tool `check-all-the-things'. It reveals
> 
>  * loads of spelling errors in po/

The 'spelling errors' are mostly ispell trying to correct non-english
translations i.e.

"./newsbeuter-2.9/po/es.po:438: Autor  ==> Author"

es.po:436-8
#: src/controller.cpp:1355 src/itemview_formaction.cpp:90
msgid "Author: "
msgstr "Autor: "

Thats clearly a translation that ispell is trying to parse as english. There
are a few minor spelling mistakes in english but very few if any are in
user-viewable files(docs) in my opinion not worth making a patch for them, they
can easily be patched upstream and pulled down at the next release.

>  * wrong formatting of your email (email is formatted this way: Name <email@bar.com>,
>    your formatting in patches/podbeuter-segfault-fix misses <> symbols)

Author: Nikos Tsipinakis <nikos@tsipinakis.com>

Formatting seems correct to me as it is?

>  * installation instruction (README) should not find way into binary package

Agreed, README has been removed from the docs, package re-uploaded.

Best Regards,
	Nikos Tsipinakis


Reply to: