On 29/02/16 23:09, Mattia Rizzolo wrote: > sorry, this took awfully long. > > On Fri, Feb 05, 2016 at 11:09:20PM +0000, Jose M Calhariz wrote: >> Amanda have release a new upstream version. My main sponsor is too >> busy for helping me. So I am searching for someone that can help >> sponsor the new release. > Ok, I can do it. > Should I use the git repository? Yes please. > Just looking through cgit, I can ask you the following things: > > * https in Vcs-Git please Done > * standards-version to 3.9.7 Done > * version restriction on tar can go away, and tar being essential:yes > the whole dep can go away Done > * are you sure the perl dep is needed? ${perl:Depends} ought to do it Done > * guessing you are using git-buildpackage, why didn't you just > `gbp import-dsc` to import the NMU? My changes are older than the NMU. So I did not tried to import the NMU. > * please push the tag for the upstream part Done > * you have a build-dep on debhelper version >= 9, but you use compat 5. > please bump the compat, after checking the differences in debhelper(7) Done > * the *.dirs files don't need to list directories for files installed by > other dh_* things, so I'm confident at least line 3,4,5 of > amanda-server.dirs are useless, haven't looked at the others The debian/rules relies on cp and install to copy the files into the directories listed in *.dirs I don't like, I would prefer the format: mkdir $dir && cp $file $dir What you recomend? > * I'm not happy with the old style rules file, but guess I can't ask > that much in this case, and I can live well with it anyway :) Thank you. This package is being tested on my backup server for some weeks. I don't want to make changes that may invalidate my tests. The version 3.3.9 is all ready available and I can change the rules style for amanda 3.3.9. > > ↑ that's the kind of things I want to see changed for me to sponsor it. > If you confirm I should look at the git repository and you're ok with me > as a sponsor please confirm so (and fix the already reported problems, > please ;)) > This is for today. Tomorrow I will look into "lintian -I --pedantic" KInd regards Jose M Calhariz
Attachment:
signature.asc
Description: OpenPGP digital signature