Bug#816611: RFS: yamllint/1.0.3-1 [ITP] -- A linter for YAML files

[Paul Wise <pabs@debian.org>]

On Fri, Mar 4, 2016 at 9:25 PM, Paul Wise wrote:
> On Fri, 2016-03-04 at 13:01 +0100, Adrien Vergé wrote:
>> Thanks, fixed upstream and repackaged as 1.0.4-1.
>> https://mentors.debian.net/package/yamllint
>
> Thanks, I'll look at this tomorrow.

Looks like you released a new version.

There was one issue to fix, I've taken the liberty of doing that myself.

https://lintian.debian.org/tags/copyright-should-refer-to-common-license-file-for-gpl.html
https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile

I added these 3 lines to the end of debian/copyright, you may want to
commit that to your git repository:

 .
 On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in "/usr/share/common-licenses/GPL-3".

After fixing that issue I've uploaded it to NEW:

http://ftp-master.debian.org/new.html

Some things you may want to do/fix:

Add a manual page, you can do that automatically using either sphinx
and sphinxcontrib-autoprogram or python3-sphinx-argparse.

Add shell completion, you can do that automatically using python3-argcomplete.

The URLs in the Vcs-* fields are 404 (see duck output below), probably
you need to point them at the right branch in the github repo.

https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-VCS-fields
https://github.com/adrienverge/yamllint/tree/packaging/

Automatic checks:

build

lintian

I: yamllint source: vcs-field-uses-insecure-uri vcs-git
git://anonscm.debian.org/collab-maint/yamllint.git
P: yamllint source: debian-watch-may-check-gpg-signature
P: yamllint: no-upstream-changelog
E: yamllint: copyright-should-refer-to-common-license-file-for-gpl
W: yamllint: description-synopsis-starts-with-article
W: yamllint: binary-without-manpage usr/bin/yamllint

check-all-the-things

$ find .. -maxdepth 1 -type f -iwholename '../*.build' -exec grep -H
-i warn {} +
../yamllint_1.1.0-1_amd64.build:dpkg-gencontrol: warning: Depends
field of package yamllint: unknown substitution variable
${shlibs:Depends}

$ cme check dpkg
...
Warning in 'control source Vcs-Git' value
'git://anonscm.debian.org/collab-maint/yamllint.git': An unencrypted
transport protocol is used for this URI. It is recommended to use a
secure transport such as HTTPS for anonymous read-only access.
Warning in 'control source Vcs-Git' value
'git://anonscm.debian.org/collab-maint/yamllint.git': URL to debian
system is not the recommended one (this can be fixed with 'cme fix'
command)

$ duck
E: debian/control: Vcs-Browser:
https://anonscm.debian.org/cgit/collab-maint/yamllint.git: ERROR
(Certainty:certain)
   Curl:0 HTTP:404 No error

E: debian/control: Vcs-Git:
git://anonscm.debian.org/collab-maint/yamllint.git: ERROR
(Certainty:certain)
   fatal: '/git/collab-maint/yamllint.git' does not appear to be a git
repository
   fatal: Could not read from remote repository.

   Please make sure you have the correct access rights
   and the repository exists.

$ fdupes -q -r . | grep -vE
'/(\.(git|svn|bzr|hg|sgdrawer)|_(darcs|FOSSIL_)|CVS)(/|$)' | cat -s
./tests/yaml-1.2-spec-examples/example-5.5
./tests/yaml-1.2-spec-examples/example-5.1

./tests/yaml-1.2-spec-examples/example-8.11
./tests/yaml-1.2-spec-examples/example-8.10

./PKG-INFO
./yamllint.egg-info/PKG-INFO

# check if these can be switched to https://
$ grep -rF http: .
./tests/test_linter.py:# along with this program.  If not, see
<http://www.gnu.org/licenses/>.
./tests/test_config.py:# along with this program.  If not, see
<http://www.gnu.org/licenses/>.
<lots>

$ find -type f -iname '*.py' -exec pylint
--msg-template='{abspath}:{line}:{column}: [{category}:{symbol}]
{obj}: {msg}' --reports=n {} +
<lots>

$ find -type d \( -iname .bzr -o -iname .git -o -iname .hg -o -iname
.svn -o -iname CVS -o -iname RCS -o -iname SCCS -o -iname _MTN -o
-iname _darcs -o -iname .pc -o -iname .cabal-sandbox -o -iname .cdv -o
-iname .metadata -o -iname CMakeFiles -o -iname _build -o -iname
_sgbak -o -iname autom4te.cache -o -iname blib -o -iname cover_db -o
-iname node_modules -o -iname '~.dep' -o -iname '~.dot' -o -iname
'~.nib' -o -iname '~.plst' \) -prune -o -type f ! \( -iname '*.bak' -o
-iname '*.swp' -o -iname '#.*' -o -iname '#*#' -o -iname 'core.*' -o
-iname '*~' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' -o
-iname '*.png' -o -iname '*.min.js' -o -iname '*.js.map' -o -iname
'*.js.min' -o -iname '*.min.css' -o -iname '*.css.map' -o -iname
'*.css.min' \) -exec spellintian --picky {} +
./tests/yaml-1.2-spec-examples/example-2.3: american -> American
./docs/quickstart.rst: python -> Python
./docs/Makefile: latex -> LaTeX
./yamllint/rules/line_length.py: splitted -> split
./yamllint/rules/empty_lines.py: serie -> series

$ grep -riE 'fixme|todo|hack|xxx|broken' .
...
./yamllint/cli.py:    # TODO: read from stdin when no filename?

-- 
bye,
pabs

https://wiki.debian.org/PaulWise