[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#815027: RFS: ocrmypdf/4.0.5-1 [ITP] -- add an OCR text layer to PDF files



Control: retitle -1 RFS: ocrmypdf/4.0.7-1 [ITP] -- add an OCR text layer to PDF files

Hello,

Thanks again for the review, and for taking ownership of this RFS.

On Thu, Mar 03, 2016 at 12:39:04AM +0000, Mattia Rizzolo wrote:
> * somehow, it doesn't build on my local pbuilder (attached full build
>   log), I'd welcome hints about what went wrong here.

The errors suggest that the test suite can't write the files it needs
to.  Maybe because your pbuilder runs in tmpfs?  After the build fails
and you are dropped to a shell, does `echo "hello" > tests/resources/foo
&& rm -r tests` work?

Anyway, I've upgraded to 4.0.7 in the repository and it builds in an
up-to-date sid pbuilder on my machine.  Perhaps you could try again with
the new version.

> * on sbuild (on debomatic) it did build, but autopkgtest failed
> http://debomatic-amd64.debian.net/distribution#unstable/ocrmypdf/4.0.5-1/autopkgtest

I think I've fixed this; adt-run passes on my machine.  I'm waiting for
an account on debomatic so it would be great if you could upload it
there again.

> * it would be nice if the MIT license in d/copyright would be retitle
> as Expat, to be more precise.

Aha, I didn't know the difference :)  Thanks for teaching me about that.

> Another thing: what would you think about keeping the packaging of this
> in collab-maint?  I shall assume you don't have access to it, but I'd be
> happy to advocate you for that!

If the package became collaboratively maintained then I would be happy
to upload it there, but while it's just me, I'd prefer just to leave it
where it is for simplicity.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: