Bug#808783: RFS: openviewerfx [ITP] Open Source JavaFX PDF Viewer
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hello Markus:
Firstly I apologies for my very late reply.
Secondly, thanks you for your sponsorship.
On 07/01/16 11:10, Markus Koschany wrote:
> Control: tags -1 moreinfo
>
> Am 22.12.2015 um 22:45 schrieb Jerome Benoit:
>> Package: sponsorship-requests
>> Severity: normal
>>
>> Dear Mentors:
>>
>> I am looking for a sponsor for the package openviewerfx [1],
>> a Java library to manipulate PDF material (which is the
>> successor of the jpedal java library).
>
> Hello Jerome,
>
> Here are some initial remarks:
>
> Your package fails to build from source with this error message.
>
> src/org/jpedal/io/CertificateReader.java:69: error: method getContent in
> class RecipientInformation cannot be applied to given types;
> envelopedData = recipientInfo.getContent(key,
> provider);
> ^
> required: Recipient
> found: Key,String
> reason: actual and formal argument lists differ in length
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 1 error
> debian/rules:17: recipe for target 'override_jh_build-indep' failed
I can now reproduce this issue on my box with pbuilder (it did not
show up at the time of uploading):
I have just filed a ticket issue on GitHUB:
https://github.com/IDRSolutions/maven-OpenViewerFX-src/issues/4
>
>
> Where exactly did you download the sources from? I understand that they
> didn't release a new version back then, but you should always ensure
> that someone can compare the original sources with your tarball by
> either describing the necessary steps in README.source or by providing a
> get-orig-source target or both. By the way it seems they have released a
> new version on sourceforge.net now.
>
> http://sourceforge.net/projects/openviewerfx/files/2015_12/
>
> debian/repack:
>
> There is nothing wrong with a separate script for repacking the sources
> but you might also want to consider to use the Files-Excluded mechanism
> with debian/copyright format 1.0 which is IMO a better and standardized
> solution which avoids the reinvention of the wheel for every new
> package. For custom get-orig-source targets I can also recommend:
>
> https://wiki.debian.org/onlyjob/get-orig-source
At the time of uploading, the source had an intricate name and was at source forge.
Meanwhile the upstream maintainer moved from SF to GitHub:
https://github.com/IDRSolutions/maven-OpenViewerFX-src
Currently there is no name issue because there is no name.
I can managed the downloading and the version checking with the recent uscan (version 4)
[thanks to Paul Wise]: I emitted an issue about this lake of tag, still in progress:
https://github.com/IDRSolutions/maven-OpenViewerFX-src/issues/3
>
> Since openviewerfx is an application, you must provide some sort of
> wrapper to launch the Java app. You can either use java-wrappers (See
> example [1] and [2]) or your package should depend on jarwrapper.
I am not sure about that because OpenViewerFX is mainly a library.
Nevertheless, there are some samples: I will have a look.
This issue is minor compare to the building failure.
>
> debian/control:
>
> Please use https for the Vcs-Browser field.
The Debian material has been clean up and refresh wrt to the new upstream source git
repository at GitHub.
>
> I get into more details when you fix the compile issue and provide a way
> to download and compare the original sources with your tarball.
>
> Regards,
Thanks,
Jerome
>
> Markus
>
>
>
> [1]
> https://sources.debian.net/src/mediathekview/10-2/debian/bin/mediathekview/
> [2]
> https://sources.debian.net/src/electric/9.06%2Bdfsg-1/debian/bin/electric/
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJW15csAAoJEIC/w4IMSybjU00IAIvUKb3QX/Q8H6sHFsNfmFWf
Hx9vXTiGGRztSe8ANE/cMJDcRf97POEJxdmLWPoMtuuJtb1PkDORs+AaMkLqMDKM
x6TN+uHTBFuBAN0MQtMz+CEvbF9fZ0/oSbLhJhzdfOPXUE1NLBlKw1uV1/r4AyzM
6Bg6JBZfxVhx5WiDT2rO3rH0lOSPjo2TvmqGbgcHDJB+P0Zbg9Ps90Ou+Kduw/vv
alqvQCJPAqsIQzb1ku55OTc+0yJG1xWrU5lcxljabJWMBwVtCR3/KtVz4WVEj6e7
UK3ABFxekTKRLr6xIm2XV1j0JCPyu6k8kNupX6ud9y9MmAjVHd/JqIpg1gYbZcE=
=dBOc
-----END PGP SIGNATURE-----
Reply to: